Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Common super-type of input, select, textarea elements #12585

Closed
DartBot opened this issue Aug 21, 2013 · 11 comments
Closed

Feature request: Common super-type of input, select, textarea elements #12585

DartBot opened this issue Aug 21, 2013 · 11 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Aug 21, 2013

This issue was originally filed by @budde377


Right now if you want to iterate elements, containing a name and a value, in a form, you have to cast each element to its respective type or choose to ignore the types, which result in some problems when compiling (and/or running) the checked-mode dart2js produced javascript code.

A solution to this problem would be to create a common supertype to input, select and textarea, which contains their common properties.

@iposva-google
Copy link
Contributor

Added Area-HTML, Triaged labels.

@efortuna
Copy link
Contributor

Added this to the M7 milestone.

@blois
Copy link
Contributor

blois commented Oct 2, 2013

Should be able to add a common interface for these.


Removed this from the M7 milestone.
Added this to the M8 milestone.
Removed Type-Defect, Priority-Unassigned labels.
Added Type-Enhancement, Priority-Low labels.

@efortuna
Copy link
Contributor

efortuna commented Oct 3, 2013

Issue #4113 has been merged into this issue.

@blois
Copy link
Contributor

blois commented Oct 3, 2013

Added Community-StarterBug label.

@blois
Copy link
Contributor

blois commented Oct 16, 2013

Basic API set that I believe would be on this:
  String formTarget;

  bool disabled;

  String name;

  bool get willValidate;

  bool checkValidity();

  void setCustomValidity(String error);

  String get validationMessage;

  ValidityState get validity;

Elements which this would apply to: button fieldset input keygen object output select textarea
from:
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#category-listed

@DartBot
Copy link
Author

DartBot commented Oct 17, 2013

This comment was originally written by @budde377


It would be really nice to get

   String value

in this as well, even through this might mean omitting some of the elements you mention.

@blois
Copy link
Contributor

blois commented Oct 18, 2013

Adding value would bump the types down to:
button input output select textarea

I'm going to move this out of M8 as it's easy enough to add and I think we should consider it a bit more.


Removed this from the M8 milestone.
Added this to the Later milestone.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@DartBot DartBot added Type-Enhancement P3 A lower priority bug or feature request area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Aug 4, 2014
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

8 participants