Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js should format V8 stack traces like the VM #12575

Closed
nex3 opened this issue Aug 20, 2013 · 8 comments
Closed

dart2js should format V8 stack traces like the VM #12575

nex3 opened this issue Aug 20, 2013 · 8 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@nex3
Copy link
Member

nex3 commented Aug 20, 2013

V8 provides an API for controlling the formatting of stack traces (see https://code.google.com/p/v8/wiki/JavaScriptStackTraceApi). dart2js should take advantage of this capability and make stack traces look like they do on the Dart VM.

This is especially important for V8 because the stack traces are otherwise very difficult to parse, since they include the string representation of the Exception itself. This means that the trace can include arbitrary text before the actual trace begins, making it impossible to parse accurately in some cases.

@peter-ahe-google
Copy link
Contributor

Unfortunately, Error.prepareStackTrace is not supported anymore :-(

The V8 team has removed a lot of Error properties that dart2js used to take advantage of.

I do think we should try to format stack traces, but I really don't think the VM's format is that readable.

@nex3
Copy link
Member Author

nex3 commented Sep 5, 2013

Worth noting that issue #13095 is now tracking potential improvements to the VM's stack trace format.

@peter-ahe-google
Copy link
Contributor

I'm looking into removing the string representation of the exception.

@peter-ahe-google
Copy link
Contributor

Added Started label.

@kasperl
Copy link

kasperl commented Sep 18, 2013

Added this to the M7 milestone.

@kasperl
Copy link

kasperl commented Sep 23, 2013

Removed this from the M7 milestone.
Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed Priority-Medium labels Mar 1, 2016
@sigmundch sigmundch added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

5 participants