Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would like an option to sort in source code order for class members #12513

Closed
DartBot opened this issue Aug 16, 2013 · 13 comments
Closed

would like an option to sort in source code order for class members #12513

DartBot opened this issue Aug 16, 2013 · 13 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Aug 16, 2013

This issue was originally filed by mcam...@google.com


Source code is usually ordered in functional groupings. This is a good way to scan a class.

Also, it would make editing the docs easier.

mem

@sethladd
Copy link
Contributor

Removed Type-Defect label.
Added Type-Enhancement, Triaged labels.

@alan-knight
Copy link
Contributor

I like that idea, but it would require some enhancements to docgen to provide the information.


Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium, Library-Docgen labels.

@alan-knight
Copy link
Contributor

And is likely not possible if we're using mirrors to extract the information, as they don't provide the source code ordering.


Removed Priority-Medium label.
Added Priority-Low label.

@DartBot
Copy link
Author

DartBot commented Jan 13, 2014

This comment was originally written by @seaneagan


Hmm, the fact that dart2js mirrors doesn't expose the order would seem like a bug, especially since it is exposed via DeclarationMirror.declarations in the runtime mirrors, as seen in this quick test:

https://gist.github.com/seaneagan/8408456

I would file a bug, but I'm not sure what was tried that didn't work. Care to file a bug for it?

@alan-knight
Copy link
Contributor

I don't think it's specified to give them in any order. We could hope that it consistently does so across three different implementations. It might work, just because the default Map is a LinkedHashMap which preserves order in keys, but all it needs is for one of those parsers to start doing things out of order or use a non-linked hash map as an optimization and it would stop working.

@anders-sandholm
Copy link
Contributor

Removed Area-DartDocNext label.
Added Area-DartDoc label.

@anders-sandholm
Copy link
Contributor

Removed Library-Docgen label.

@kevmoo
Copy link
Member

kevmoo commented Mar 17, 2014

Added Pkg-DartDoc label.

@kevmoo
Copy link
Member

kevmoo commented Mar 17, 2014

Removed Area-DartDoc label.
Added Area-Pkg label.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Pkg-DartDoc label.
Added Pkg-DocGen label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@sethladd
Copy link
Contributor

Moved to dart-lang/dartdoc#96


Added MovedToGithub label.

@DartBot DartBot added Type-Enhancement P3 A lower priority bug or feature request area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jan 12, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

6 participants