Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM has incorrect RegExp implementation #12508

Closed
ghost opened this issue Aug 16, 2013 · 8 comments
Closed

VM has incorrect RegExp implementation #12508

ghost opened this issue Aug 16, 2013 · 8 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Milestone
1.9

Comments

@ghost
Copy link

ghost commented Aug 16, 2013

LibTest/core/RegExp/Pattern_semantics/firstMatch_Term_A03_t01: Fail
LibTest/core/RegExp/Pattern_semantics/firstMatch_Atom_A02_t01: Fail
LibTest/core/RegExp/Pattern_semantics/firstMatch_DecimalEscape_A01_t02: Fail
LibTest/core/RegExp/Pattern_semantics/firstMatch_CharacterClassEscape_A03_t01: Fail
LibTest/core/RegExp/Pattern_semantics/firstMatch_CharacterClassEscape_A04_t01: Fail
LibTest/core/RegExp/Pattern_semantics/firstMatch_NonEmptyClassRanges_A01_t01: Fail
LibTest/core/RegExp/Pattern_semantics/firstMatch_CharacterEscape_A06_t02: Fail
LibTest/core/RegExp/Pattern_semantics/firstMatch_NonEmptyClassRanges_A01_t05: Fail
LibTest/core/RegExp/Pattern_semantics/firstMatch_NonEmptyClassRanges_A01_t06: Fail
@whesse
Copy link
Member

whesse commented Sep 30, 2014

The test LibTest/core/RegExp/Pattern_semantics/firstMatch_Term_A04_t01 is now failing, because a RegExp that does not match should return null for the matches of its groups, not the empty string.

See co19 issues
https://code.google.com/p/co19/issues/detail?id=710
and
https://code.google.com/p/co19/issues/detail?id=92

cc @lrhn.
cc @peter-ahe-google.

@lrhn
Copy link
Member

lrhn commented Nov 10, 2014

Issue #21544 has been merged into this issue.

@sethladd
Copy link
Contributor

Can we close this now?

@sethladd
Copy link
Contributor

Added this to the 1.9 milestone.

@iposva-google
Copy link
Contributor

Set owner to zerny...@google.com.
Removed this from the 1.9 milestone.
Added Accepted label.

@DartBot
Copy link

DartBot commented Jan 29, 2015

This comment was originally written by zerny...@google.com

The following are fixed in r42312:
  LibTest/core/RegExp/Pattern_semantics/firstMatch_Term_A03_t01
  LibTest/core/RegExp/Pattern_semantics/firstMatch_Atom_A02_t01
  LibTest/core/RegExp/Pattern_semantics/firstMatch_CharacterClassEscape_A03_t01
  LibTest/core/RegExp/Pattern_semantics/firstMatch_CharacterClassEscape_A04_t01

The remaining issues appear to be general issues with the tests or libraries. Opened issue #22200 to track this. Closing this issue.

Added Fixed label.

@DartBot
Copy link

DartBot commented Jan 29, 2015

This comment was originally written by zerny...@google.com

Added this to the 1.9 milestone.
Removed Priority-Unassigned label.

@DartBot
Copy link

DartBot commented Jan 29, 2015

This comment was originally written by zerny...@google.com

Issue #21544 has been merged into this issue.

@ghost ghost added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Jan 29, 2015
@ghost ghost added this to the 1.9 milestone Jan 29, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
5 participants
@sethladd @lrhn @whesse @iposva-google @DartBot