Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM: importing dart:core with a prefix hides dynamic #12478

Closed
rmacnak-google opened this issue Aug 15, 2013 · 4 comments
Closed

VM: importing dart:core with a prefix hides dynamic #12478

rmacnak-google opened this issue Aug 15, 2013 · 4 comments
Labels
area-vm closed-not-planned Closed as we don't intend to take action on the reported issue type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@rmacnak-google
Copy link
Contributor

import 'dart:core' as core;

main(){
  // Should still be available because it is not a member of dart:core.
  Expect.isTrue(dynamic is Type);
  
  Expect.throws(() => mycore.dynamic is Type,
                (e) => e is NoSuchMethodError,
                'dynamic is not a member of dart:core');
}

@zanderso
Copy link
Member

zanderso commented Jan 5, 2017

@mhausner @rmacnak-google This appears to still happen, but is it still incorrect? Is this issue stale?

@rmacnak-google
Copy link
Contributor Author

I believe this issue is still valid.

tests/language/dynamic_prefix_core_test.dart isn't marked as failing for kernel though, so it will probably end up fixed by the new front end.

@mhausner mhausner removed their assignment Jan 9, 2017
@mhausner mhausner added closed-not-planned Closed as we don't intend to take action on the reported issue and removed area-kernel labels Jan 9, 2017
@mhausner mhausner self-assigned this Jan 9, 2017
@mhausner
Copy link
Contributor

mhausner commented Jan 9, 2017

This is still valid, but will be obsolete with the new front-end. I don't see a reason to fix this for the current front-end.

As @rmacnak-google observes, this works in the new Front-end, so closing the issue.

@eernstg
Copy link
Member

eernstg commented Feb 6, 2018

This is closed, but in case anyone ever takes a look here: Please note that dynamic is exported by 'dart:core', and tests/language{,_2}/import_core_prefix_test.dart need to be updated as described in #32060.

dart-bot pushed a commit that referenced this issue Feb 7, 2020
Bug: #12478
Bug: #40497
Bug: #40510
Change-Id: I841d7e239b8235555ec26fbcb74ca41b5de60f58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134806
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
dart-bot pushed a commit that referenced this issue Feb 7, 2020
…embedding API for dynamic, void and Never.

Fix crash when create type errors involving Never.

Bug: #12478
Bug: #40176
Change-Id: I8cff7042850717d02da36ad935cf0a49ace80c3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134886
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm closed-not-planned Closed as we don't intend to take action on the reported issue type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

5 participants