Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test runner Dart script uses Path class from dart:io #12449

Closed
sgjesse opened this issue Aug 14, 2013 · 8 comments
Closed

Test runner Dart script uses Path class from dart:io #12449

sgjesse opened this issue Aug 14, 2013 · 8 comments
Assignees
@whesse
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. closed-obsolete Closed as the reported issue is no longer relevant P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@sgjesse
Copy link
Contributor

sgjesse commented Aug 14, 2013

The Path class will be removed from the dart:io package (issue #11666). The test runner scripts needs to stop using this class before updating the checked-in Dart VM is possible.

The path package contains equivalent features working directly on String objects.
@mkustermann
Copy link
Member

Set owner to @mkustermann.
Added Accepted label.

@whesse
Copy link
Member

whesse commented Oct 23, 2013

This issue has been resolved by making a private copy of the Path class in tools/testing/dart/utils.dart. So the checked-in Dart VM has been updated, and can be updated further.

Eventually, someone should rewrite the test runner scripts to use either URI, or a local copy of package path (with the mirror code replaced by URI.base) (a local copy because the test runner should not depend on package imports).

The unit tests of the test runner scripts now pass, so I am removing them from the status file.

Added this to the Later milestone.
Removed Type-Defect, Priority-Unassigned labels.
Added Type-CodeHealth, Priority-Low labels.

@mkustermann
Copy link
Member

Correct, the testing scripts use tools/testing/dart/legacy_path.dart now.

Changing the scripts to use URI and updating the checked-in binary has very low priority right now.

@ricowind
Copy link
Contributor

Bill will update the checked in binaries when he is back from vacation

Set owner to @whesse.

@ricowind
Copy link
Contributor

Removed this from the Later milestone.
Added this to the 1.1 milestone.
Removed Area-Test label.
Added Area-Infrastructure label.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.1 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@sgjesse sgjesse added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P3 A lower priority bug or feature request area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. Accepted labels Aug 4, 2014
@kevmoo kevmoo removed the accepted label Feb 29, 2016
@lrhn lrhn added the closed-obsolete Closed as the reported issue is no longer relevant label Sep 14, 2020
@lrhn lrhn closed this as completed Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. closed-obsolete Closed as the reported issue is no longer relevant P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevmoo @sgjesse @kasperl @lrhn @whesse @ricowind @mkustermann