Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect if OS is 32 or 64 bit and determine test status accordingly. #1220

Closed
efortuna opened this issue Jan 18, 2012 · 4 comments
Closed

Detect if OS is 32 or 64 bit and determine test status accordingly. #1220

efortuna opened this issue Jan 18, 2012 · 4 comments
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug

Comments

@efortuna
Copy link
Contributor

Regardless of whether we always build the 32-bit version of dart, running the tests in 32-bit or 64-bit versions of the browsers can have different effects. For example, ToStringAsFixedTest passes in Safari 32-bit mode, but fails in 64-bit mode. CrossIsolateMessageTest, Mixed2Test, and MixedTest also have different behavior depending on Safari's mode.

We should add some additional specification to the .status files to list whether we expect such tests to pass or fail depending on the version of browser/OS we're running. For now, I am marking these tests as Pass,Fail ("flaky") so that others running these tests locally won't be confused by test failures that are not really their fault.
@whesse
Copy link
Member

whesse commented Jun 12, 2012

Added this to the Later milestone.

@ricowind
Copy link
Contributor

Removed Area-Test label.
Added Area-Infrastructure label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@efortuna efortuna added Type-Enhancement area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged type-enhancement A request for a change that isn't a bug labels Feb 29, 2016
@lrhn lrhn added closed-obsolete Closed as the reported issue is no longer relevant and removed P2 A bug or feature request we're likely to work on labels Oct 14, 2019
@lrhn lrhn closed this as completed Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @efortuna @kasperl @lrhn @whesse @ricowind