Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DartEditor error highlighting wrong #12100

Closed
DartBot opened this issue Jul 29, 2013 · 8 comments
Closed

DartEditor error highlighting wrong #12100

DartBot opened this issue Jul 29, 2013 · 8 comments
Labels
analyzer-recovery area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jul 29, 2013

This issue was originally filed by joh...@johnmccutchan.com


By adding an extra ")" character the editor error highlighting goes nuts giving me many false errors. Removing the extra ")" clears it up. The VM's parser correctly identified the error as the extra ")" character.

See two screenshots. Text here:

final Map<String, AttributeConstructor> spectreAttributeDefinitions = {
    'fieldOfViewY': () => new SpectreElementAttributeDouble('fieldOfViewY',
                                                            0.785398163),
    'position': () => new SpectreElementAttributeVector3('position',
                                                         new Vector3(1.0, 1.0,
                                                                     1.0)),
    'upDirection': () => new SpectreElementAttributeVector3('upDirection',
                                                         new Vector3(0.0, 1.0,
                                                                     0.0)),
    'viewDirection': () =>
        new SpectreElementAttributeVector3('viewDirection',
                                           new Vector3(-0.33333, -0.33333,
                                                       -0.33333)),
    'zNear': () => new SpectreElementAttributeDouble('zNear', 0.5),
    'zFar': () => new SpectreElementAttributeDouble('zFar', 1000.0),
  };


Attachments:
with.png (327.41 KB)
without.png (320.03 KB)

@madsager
Copy link
Contributor

Added Area-Editor, Triaged labels.

@clayberg
Copy link

Set owner to @bwilkerson.
Added this to the M6 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@bwilkerson
Copy link
Member

Removed this from the M6 milestone.
Added this to the Later milestone.
Removed Type-Defect, Area-Editor labels.
Added Type-Enhancement, Area-Analyzer labels.

@sethladd
Copy link
Contributor

Issue #12792 has been merged into this issue.

1 similar comment
@clayberg
Copy link

Issue #12792 has been merged into this issue.

@bwilkerson
Copy link
Member

Added Analyzer-Recovery label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@DartBot DartBot added Type-Enhancement area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-recovery labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@bwilkerson bwilkerson removed their assignment Aug 15, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-recovery area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

8 participants