Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8 tests slow when compiled with dart2js #12029

Closed
floitschG opened this issue Jul 25, 2013 · 13 comments
Closed

utf8 tests slow when compiled with dart2js #12029

floitschG opened this issue Jul 25, 2013 · 13 comments
Assignees
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-obsolete Closed as the reported issue is no longer relevant

Comments

@floitschG
Copy link
Contributor

tests/lib/convert/chunked_conversion_utf88_test.dart is slow on IE9 and FF.
Might be worth looking into what makes it soo much slower than Chrome.

@floitschG
Copy link
Contributor Author

tests/lib/convert/streamed_conversion_utf8_encode_test.dart is even worse.
Completes almost instantly with the VM, but takes almost 30 seconds in Chrome.

Tentatively increasing priority since it eats up build-bot time.


cc @ricowind.
Removed Priority-Unassigned label.
Added Priority-High label.

@floitschG
Copy link
Contributor Author

streamed_conversion_utf8_decode_test just timed out too (on FF).
(Marked it as slow).

@peter-ahe-google
Copy link
Contributor

Set owner to ngeoffray@google.com.
Added Started label.

@DartBot
Copy link

DartBot commented Aug 26, 2013

This comment was originally written by ngeoffray@google.com


The test convert/chunked_conversion_utf88_test is apparently not slow in FF, but it just happens that FF may go slow on some tests randomly. Tentatively changing the area to Test, but Rico feel free to close it.

I filed bug https://code.google.com/p/dart/issues/detail?id=12768 for streamed_conversion_utf8_encode_test.dart and streamed_conversion_utf8_decode_test.dart.


Set owner to @ricowind.
Removed Area-Dart2JS label.
Added Area-Test label.
Changed the title to: "convert/chunked_conversion_utf88_test slow on IE9".

@larsbak
Copy link

larsbak commented Aug 27, 2013

Added this to the M7 milestone.

@floitschG
Copy link
Contributor Author

convert/utf85_test seems to hit the same problem.

@floitschG
Copy link
Contributor Author

utf85_test is slow when running in checked mode. Had to mark it for drt too.

Changed the summary to reflect the current state.


Changed the title to: "utf8 tests slow when compiled with dart2js".

@ricowind
Copy link
Contributor

Checked mode is 35X slower than normal mode, is that something we want to do something about?


Removed this from the M7 milestone.
Added this to the 1.1 milestone.
Removed Priority-High label.
Added Priority-Medium label.

@ricowind
Copy link
Contributor

actually cc some people for input


cc @kasperl.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.1 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@ricowind
Copy link
Contributor

ricowind commented Jun 2, 2015

Added AssumedStale label.

@floitschG floitschG added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-obsolete Closed as the reported issue is no longer relevant labels Jun 2, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Development

No branches or pull requests

6 participants