Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't skip LibTest/core/List/sort_A01_t04 on jsshell #11992

Closed
peter-ahe-google opened this issue Jul 24, 2013 · 1 comment
Closed

Don't skip LibTest/core/List/sort_A01_t04 on jsshell #11992

peter-ahe-google opened this issue Jul 24, 2013 · 1 comment
Labels
web-dart2js

Comments

@peter-ahe-google
Copy link
Contributor

See CL https://codereview.chromium.org/16938012/.

It seems like it was the compiler that timed out, not jsshell.

Now the status file says:

LibTest/core/List/sort_A01_t04: Pass, Timeout # Must be a bug in jsshell, test sometimes times out.

However, the test is already marked slow, and there was a bug in our test runner so that marking a test slow didn't allow the compilation longer time to complete.

I believe that the special case for jsshell should be removed now.
@sethladd sethladd added the closed-not-planned Closed as we don't intend to take action on the reported issue label Jul 10, 2015
@sigmundch sigmundch added web-dart2js and removed Area-Dart2Dart closed-not-planned Closed as we don't intend to take action on the reported issue labels Jul 10, 2015
@zoechi
Copy link
Contributor

zoechi commented Jul 10, 2015

Is this supposed to be reopened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sethladd @kevmoo @zoechi @sigmundch @peter-ahe-google