Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XHR tests failing to download cached URLs #11834

Open
blois opened this issue Jul 15, 2013 · 19 comments
Open

XHR tests failing to download cached URLs #11834

blois opened this issue Jul 15, 2013 · 19 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-libraries Issues impacting dart:html, etc., libraries

Comments

@blois
Copy link
Contributor

blois commented Jul 15, 2013

Some recent Chrome change appears to cause our XHR tests to fail to download URIs within a short window of Chrome being launched. If a delay of a second is added before the request is made then it succeeds. If a cache blocker is added to the URI it succeeds.

@alan-knight
Copy link
Contributor

Issue #12376 has been merged into this issue.


cc @ricowind.

@ricowind
Copy link
Contributor

Did we file a chromium bug for this?
This is happening on windows and mac builders right? These run stable chrome and this seems like very relevant info to pass along? Do we have a reproduction that is easy to verify?

@blois
Copy link
Contributor Author

blois commented Aug 13, 2013

I spent about a half day investigating but could not come up with a good repro. From what I can tell:

I was unable to repro on any setup other than via the Selenium test harness.

@blois
Copy link
Contributor Author

blois commented Aug 21, 2013

Issue #12592 has been merged into this issue.

@blois
Copy link
Contributor Author

blois commented Aug 21, 2013

Issue #11836 has been merged into this issue.

@blois
Copy link
Contributor Author

blois commented Aug 21, 2013

Wondering if Rico or Martin would have time to investigate this further- I think this comes down to Chrome behavior when running multiple tests at the same time, but I'm not sure what the best way is to simplify the environment for a Chrome repro.

Bug 11836 is probably the simplest repro code-wise as it has a data-uri failing with a network error.

@ricowind
Copy link
Contributor

Pete: Just for my education and to not spend unnecessary time on this
Did we still never see this when not running with selenium?

@ricowind
Copy link
Contributor

cc @mkustermann.

@blois
Copy link
Contributor Author

blois commented Aug 22, 2013

I could never repro outside of selenium, but not sure if it's related to selenium or just that selenium makes it easy to hit the timing issues.

For example, the test files are htmlIndividualConfig tests with multiple groups, so they execute in parallel.
  - If I comment out all of the groups except for the problematic one, then the bug does not repro.
  - If I leave the group with the error, and add one empty group, then the bug does repro.
  - If I add a delay before the test "test('delay', () => Future.delay(new Duration(seconds: 3)));" then it does not repro.
  - Manually running in a browser window never repros

I just tried making the simplified repro's that I was using when investigating earlier and I can no longer repro locally- could be that the issue has already been fixed in Chrome (29.0.1547.57)?

@ricowind
Copy link
Contributor

Thx Pete
That may very well be. Alternatively I hope we can retire selenium really soon!

@efortuna
Copy link
Contributor

Issue #11998 has been merged into this issue.

@efortuna
Copy link
Contributor

Issue #11884 has been merged into this issue.

@larsbak
Copy link

larsbak commented Aug 28, 2013

Removed this from the M6 milestone.
Added this to the M7 milestone.

@alan-knight
Copy link
Contributor

I saw this on Dartium Mac with canvasrenderingcontext2d_test/drawImage_video_element_dataUrl

@blois
Copy link
Contributor Author

blois commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@ricowind
Copy link
Contributor

ricowind commented Oct 2, 2013

This may be related to the dartium import loading issues where there is an ongoing investigation.

@blois
Copy link
Contributor Author

blois commented Oct 2, 2013

I sent Martin a patch with the same workaround that we used for this, and it didn't help for the import loading issue. But I agree, that it sounds similar.

@ricowind
Copy link
Contributor

ricowind commented Oct 2, 2013

Thanks for reminding me, I was sitting at his computer when we tried it :-). I would not rule out that the workaround is just eliminating this particular issue for other timing related issues on this test, but I can't of course be sure. We did see xhr related flake on dartium lately as well

@blois
Copy link
Contributor Author

blois commented Oct 15, 2013

Moving to later as I don't think we have any concrete changes to the DOM classes for this and don't have bandwidth for investigation in M8.


Removed this from the M8 milestone.
Added this to the Later milestone.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@vsmenon vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019
@sigmundch sigmundch added the web-libraries Issues impacting dart:html, etc., libraries label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

8 participants