Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a hint that dom elements cannot be extended #11734

Closed
stevemessick opened this issue Jul 8, 2013 · 5 comments
Closed

Need a hint that dom elements cannot be extended #11734

stevemessick opened this issue Jul 8, 2013 · 5 comments
Assignees
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@stevemessick
Copy link
Contributor

Dart doesn't allow classes such as DivElment to be extended. The editor should flag this.

// Example which is not allowed by dart and should be flagged

class ActionButton extends DivElement { // <---- display error here !!!!
  var a;

  factory ActionButton(String string) {
  text = string;
  }
}

http://stackoverflow.com/questions/13002606/how-do-i-create-composite-components-in-dart

////////////////////////////////////////////////////////////////////////////////////
Editor: 0.5.20_r24275 (2013-06-21)
OS: Windows 7 - amd64 (6.1)
JVM: 1.7.0_21

projects: 3

open dart files: 1

auto-run pub: true
localhost resolves to: 127.0.0.1
mem max/total/free: 889 / 400 / 105 MB
thread count: 27
index: 321362 relationships in 74939 keys in 238 sources

SDK installed: true
Dartium installed: true
analysis engine: new

@clayberg
Copy link

clayberg commented Apr 1, 2014

Added Analyzer-Hint label.

@bwilkerson
Copy link
Member

I agree that we don't want to special case DivElement. I think the right way to address this would be to add an annotation that the analyzer can use for this purpose and then add it to DivElement.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@stevemessick stevemessick added Type-Enhancement area-analyzer analyzer-warning Issues with the analyzer's Warning codes labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@bwilkerson
Copy link
Member

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants