Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad operator== in dart2js_mirror.dart #11641

Closed
peter-ahe-google opened this issue Jul 1, 2013 · 10 comments
Closed

Bad operator== in dart2js_mirror.dart #11641

peter-ahe-google opened this issue Jul 1, 2013 · 10 comments
Assignees
@johnniwinther
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@peter-ahe-google
Copy link
Contributor

dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:1256:17: Hint: The class "Dart2JsDynamicMirror" overrides "operator==", but not "get hashCode".
  bool operator ==(Object other) {
                ^^
dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:1224:17: Hint: The class "Dart2JsVoidMirror" overrides "operator==", but not "get hashCode".
  bool operator ==(Object other) {
                ^^
dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:1105:17: Hint: The class "Dart2JsInterfaceTypeMirror" overrides "operator==", but not "get hashCode".
  bool operator ==(Object other) {
                ^^
dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:973:17: Hint: The class "Dart2JsTypeVariableMirror" overrides "operator==", but not "get hashCode".
  bool operator ==(var other) {
                ^^
dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:850:17: Hint: The class "Dart2JsClassMirror" overrides "operator==", but not "get hashCode".
  bool operator ==(Object other) {
                ^^
@kasperl
Copy link

kasperl commented Sep 18, 2013

Added this to the M7 milestone.

@kasperl
Copy link

kasperl commented Sep 23, 2013

Is this still an issue?

Removed Priority-Unassigned label.
Added Priority-Medium label.

@johnniwinther
Copy link
Member

Yes.

@johnniwinther
Copy link
Member

It is actually a false positive, and we do not currently require a hint-free analyze_dart2js_test.

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@peter-ahe-google
Copy link
Contributor Author

It is not a false positive. The implementation in mirrors is brittle and shouldn't be written that way.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M8 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@bkonyi
Copy link
Contributor

bkonyi commented Jun 21, 2018

Closing since dart:mirrors is no longer supported for web.

@bkonyi bkonyi closed this as completed Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @kasperl @peter-ahe-google @johnniwinther @bkonyi