New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html/xhr_test/xhr is flaky on firefox #11602
Comments
Any idea when this started becoming flaky? Looking at the test, the test failure doesn't correlate to the test being executed. The test which failed is synchronous and is expecting a method to either throw an exception or return normally. The test failure in the log is a Future callback expecting true and getting false. |
[+martin since this may not be solved before I go on vacation]
Looking at the test however, shouldn't we do the following? --- xhr_test.dart (revision 24572)
cc @mkustermann. |
Nope. With the test.dart waits for futures that are returned to pass before declaring a test as PASS. See tests/html/websql_test.dart for another example |
Still needs clarification on this statement: cheers, |
Removed this from the M7 milestone. |
Removed Area-HTML label. |
Removed this from the Later milestone. |
Removed Oldschool-Milestone-Later label. |
Moving flaky test under CodeHealth. Removed the owner. |
http://build.chromium.org/p/client.dart/builders/dart2js-ff-linux/builds/8521/steps/dart2js%20tests%20failures/logs/stdio
Will mark as flaky in the status file
The text was updated successfully, but these errors were encountered: