Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html/xhr_test/xhr is flaky on firefox #11602

Closed
ricowind opened this issue Jun 28, 2013 · 12 comments
Closed

html/xhr_test/xhr is flaky on firefox #11602

ricowind opened this issue Jun 28, 2013 · 12 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@ricowind
Copy link
Contributor

http://build.chromium.org/p/client.dart/builders/dart2js-ff-linux/builds/8521/steps/dart2js%20tests%20failures/logs/stdio

Will mark as flaky in the status file

@blois
Copy link
Contributor

blois commented Jun 28, 2013

Any idea when this started becoming flaky?

Looking at the test, the test failure doesn't correlate to the test being executed.

The test which failed is synchronous and is expecting a method to either throw an exception or return normally.

The test failure in the log is a Future callback expecting true and getting false.

@ricowind
Copy link
Contributor Author

ricowind commented Jul 1, 2013

[+martin since this may not be solved before I go on vacation]

Looking at the test, the test failure doesn't correlate to the test being executed.
Please elaborate, from the output this correlates fine in what I see.

Looking at the test however, shouldn't we do the following?
Index: xhr_test.dart
===================================================================

--- xhr_test.dart (revision 24572)
+++ xhr_test.dart (working copy)
@@ -199,9 +199,9 @­@
         }
         xhr.send(data);
 

  •    return xhr.onLoad.first.then((_) {
    
  •    return xhr.onLoad.first.then(expectAsync1((_) {
    
               expect(progressCalled, isTrue);
  •    });
    
  •    }));
    
           });
         }
       });

cc @mkustermann.

@efortuna
Copy link
Contributor

efortuna commented Jul 1, 2013

Nope. With the test.dart waits for futures that are returned to pass before declaring a test as PASS. See tests/html/websql_test.dart for another example

@ricowind
Copy link
Contributor Author

ricowind commented Jul 2, 2013

Still needs clarification on this statement:
Looking at the test, the test failure doesn't correlate to the test being executed.

cheers,
Rico

@blois
Copy link
Contributor

blois commented Jul 8, 2013

Correction- the test failure is indeed the test in question.

The test attempts to use a large payload to make sure the progress events always fire, but appears to not always work.


Set owner to @blois.
Added this to the M6 milestone.
Added Accepted label.

@larsbak
Copy link

larsbak commented Aug 27, 2013

Removed this from the M6 milestone.
Added this to the M7 milestone.

@blois
Copy link
Contributor

blois commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.
Removed Priority-High label.
Added Priority-Medium label.

@blois
Copy link
Contributor

blois commented Oct 15, 2013

Moving to later as the XHR test is unstable for a variety of reasons, I do not think we can stabilize it for M8.

This specific issue appears to be an issue with the test itself rather than the implementation.


Removed this from the M8 milestone.
Added this to the Later milestone.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@alan-knight
Copy link
Contributor

Moving flaky test under CodeHealth.


Removed the owner.
Removed Type-Defect label.
Added Type-CodeHealth label.

@ricowind ricowind added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable Priority-Medium area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Jan 13, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on and removed accepted labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Development

No branches or pull requests

8 participants