Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning to the final variable is warning, not error #11591

Open
scheglov opened this issue Jun 28, 2013 · 8 comments
Open

Assigning to the final variable is warning, not error #11591

scheglov opened this issue Jun 28, 2013 · 8 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@scheglov
Copy link
Contributor

language/final_for_in_variable_test/01

12.18 Assignment

It is as static warning if an assignment of the form v = e occurs inside a
top level or static function (be it function, method, getter, or setter) or variable
initializer and there is no declaration d with name v = in the lexical scope
enclosing the assignment.

@scheglov
Copy link
Contributor Author

language/final_param_negative_test
language/final_var_negative_test
language/final_variable_assignment_test/01
language/final_variable_assignment_test/02
language/final_variable_assignment_test/03
language/final_variable_assignment_test/04

@scheglov
Copy link
Contributor Author

language/getter_no_setter_test/01

@ricowind
Copy link
Contributor

cc @kasperl.
cc @peter-ahe-google.

@sgjesse
Copy link
Contributor

sgjesse commented Aug 22, 2013

The tests

final_var_negative_test: Fail
final_variable_assignment_test/01: Fail
final_variable_assignment_test/03: Fail
final_variable_assignment_test/04: Fail
final_variable_assignment_test/02: Fail

Are ok, see https://code.google.com/p/dart/source/detail?r=26519.

@larsbak
Copy link

larsbak commented Aug 28, 2013

Removed this from the M6 milestone.
Added this to the M7 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M7 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@scheglov scheglov added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Aug 4, 2014
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

6 participants