Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM should compile with -Wconversion #11526

Closed
floitschG opened this issue Jun 26, 2013 · 2 comments
Closed

VM should compile with -Wconversion #11526

floitschG opened this issue Jun 26, 2013 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@floitschG
Copy link
Contributor

The -Wall flag does not include -Wconversion which warns when assignments truncate numbers (like int = int64, short = int, ...).
The VM should add this flag to its standard flags.
Currently there are several places in the VM where the warning would trigger. So these need to be fixed first.
@floitschG floitschG added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Jun 26, 2013
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@zanderso zanderso added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable and removed type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jan 5, 2017
@zanderso
Copy link
Member

zanderso commented Jan 5, 2017

There are now 100s of these. This would be a fairly serious clean-up.

@mraleph
Copy link
Member

mraleph commented Mar 12, 2018

I don't think we are planning to go through this cleanup any time soon.

@mraleph mraleph closed this as completed Mar 12, 2018
@rmacnak-google rmacnak-google mentioned this issue Mar 6, 2019
Open
@rmacnak-google rmacnak-google mentioned this issue Sep 4, 2019
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @mraleph @zanderso @floitschG