Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocks tests are not statically negative #11517

Closed
scheglov opened this issue Jun 26, 2013 · 7 comments
Closed

Mocks tests are not statically negative #11517

scheglov opened this issue Jun 26, 2013 · 7 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@scheglov
Copy link
Contributor

  Please fix these tests to make them statically negative.
  Otherwise, I'd like to know if it is fine to mark them as "fail, OK" in status files.

unittest/test/mock_regexp_negative_test: fail
unittest/test/mock_stepwise_negative_test: fail
@gramster
Copy link
Contributor

The tests should be skipped by dartc and the analyzer now.

Added Fixed label.

@peter-ahe-google
Copy link
Contributor

Graham, it would be great if you could update the tests to use the multitest feature instead of ..._negative_test.dart.

We want to get rid of negative tests because we want to ensure that tests are failing for the right reason. Also, we don't really want to skip tests unless there is no other solution.

Added Triaged label.

@larsbak
Copy link

larsbak commented Aug 28, 2013

Removed this from the M6 milestone.
Added this to the M7 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M7 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@scheglov scheglov added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Aug 4, 2014
@srawlins
Copy link
Member

No more mock*_negative_test files.

@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevmoo @srawlins @scheglov @kasperl @gramster @peter-ahe-google @larsbak