Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js does not always generate computeSignature when needed #11470

Closed
johnniwinther opened this issue Jun 24, 2013 · 9 comments
Closed

dart2js does not always generate computeSignature when needed #11470

johnniwinther opened this issue Jun 24, 2013 · 9 comments
Assignees

Comments

@johnniwinther
Copy link
Member

dart2js does not always generate computeSignature when needed:

lib/async/catch_errors20_test

@DartBot
Copy link

DartBot commented Jul 15, 2013

This comment was originally written by everton.ma...@gmail.com


I am hitting a possibly related issue. Unsure if I should open a separate report.

With current Dart Editor (Dart SDK version 0.6.3.3_r24898) my code started
to throw this exception:

NoSuchMethodError : method not found: 'Object [object Object] has no method 'computeSignature''
Receiver: ""
Arguments: []

The offending code is the call copy.forEach(_partTable.remove) from below:

    Map<String,Part> _partTable = new Map<String,Part>();

    // ... snip ...

    Iterable<String> keys = _partTable.keys;
    Iterable<String> filtered = keys.where((name) {
      bool empty = _partTable[name].indexListSize < 1;
      if (empty) {
        print("OBJ: deleting empty object=$name");
      }
      return empty;
    });
    List<String> copy = filtered.toList();
    copy.forEach(_partTable.remove);

This code works cleanly on the previous SDK (*) (with Dartium VM, dart2js and dart2js -c).

On the current SDK (**), the exception is thrown only with "dart2js -c".

Unfortunately I am unable to reproduce the issue with a standalone test case.

If you need any additional info to pinpoint this issue, please let me know.

(*) Previous SDK:
Dart Editor version 0.5.20_r24275
Dart SDK version 0.5.20.4_r24275

(**) Current SDK:
Dart Editor version 0.6.3_r24898
Dart SDK version 0.6.3.3_r24898

@DartBot
Copy link

DartBot commented Jul 18, 2013

This comment was originally written by everton.ma...@gmail.com


Tried the newer Dart Editor:

Dart Editor version 0.6.5_r25017
Dart SDK version 0.6.5.0_r25017

With this new DK, my code no longer throws the exception.
The offending code is unchanged though.
I'm clueless, unfortunately.

@kasperl
Copy link

kasperl commented Sep 18, 2013

Added this to the M7 milestone.

@kasperl
Copy link

kasperl commented Sep 30, 2013

Removed Priority-Unassigned label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M8 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@sigmundch
Copy link
Member

Seems this was fixed long ago (around r24915)


Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants