Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM RegExp's matchAsPrefix is inefficient. #11276

Closed
lrhn opened this issue Jun 13, 2013 · 3 comments
Closed

VM RegExp's matchAsPrefix is inefficient. #11276

lrhn opened this issue Jun 13, 2013 · 3 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-obsolete Closed as the reported issue is no longer relevant type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@lrhn
Copy link
Member

lrhn commented Jun 13, 2013

It currently matches at the specified point or later, and then discards later matches.
It would be best if it only attempted a match at the specified start point.

If jscre does not support this, it might be necessary to create a different RegExp by appending "|()" to the original, and test using that - this will always match at the given position, and we can recognize if it was the added group that matched and not the original regexp.
@nex3
Copy link
Member

nex3 commented May 29, 2014

Marked this as blocking #19090.

@DartBot
Copy link

DartBot commented Jan 29, 2015

This comment was originally written by zerny...@google.com

With the new RegExp implementation matching is not slow in general. That said, the implementation of matchAsPrefix is unchanged so I'm leaving this issue open.

@DartBot
Copy link

DartBot commented Jan 29, 2015

This comment was originally written by zerny...@google.com

Unmarked this as blocking #19090.

@lrhn lrhn added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Jan 29, 2015
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@iposva-google iposva-google added the closed-obsolete Closed as the reported issue is no longer relevant label May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-obsolete Closed as the reported issue is no longer relevant type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nex3 @kevmoo @lrhn @iposva-google @DartBot