Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sourcemaps with "package:" imports in dartium #11226

Closed
sigmundch opened this issue Jun 12, 2013 · 11 comments
Closed

support sourcemaps with "package:" imports in dartium #11226

sigmundch opened this issue Jun 12, 2013 · 11 comments
Assignees
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@sigmundch
Copy link
Member

Sourcemaps when using 'package:' imports might have been working before, but it doesn't seem to be working anymore. The following files can be used to repro the problems (they are also attached in a tar ball below):

index.html:

  <html><body><script> navigator.webkitStartDart();</script>
  <script type="application/dart">
    import 'package:p/a.dart' as a;
    main() => a.m();
  </script></body>

packages/p/a.dart:

  library a;
  m() => print("hi");
  //@ sourceMappingURL=a.map

packages/p/a.map:

  {"version":3,"sourceRoot":"","sources":[],"names":[],"mappings":"","file":"packages/foo/a.dart"}

The last file exists, but the contents are not really relevant.

If I use a file:/// URL to load this application, we don't seem to attempt to load the .map file.

If using a local server, the request for the .map file incorrectly includes a 'package:' string in the request.

For example, "http://localhost:8000/package:p/a.map"


Attachment:
source_map_bug.tar (10 KB)

@jacob314
Copy link
Member

Added Fixed label.

@DartBot
Copy link

DartBot commented Jul 1, 2013

This comment was originally written by podivilov@google.com


Set owner to @jacob314.
Added Accepted label.

@larsbak
Copy link

larsbak commented Aug 27, 2013

Added this to the M7 milestone.

@vsmenon
Copy link
Member

vsmenon commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@dgrove
Copy link
Contributor

dgrove commented Oct 17, 2013

Do we really need this for M8?

@jacob314
Copy link
Member

I don't think this should be an m8 item given that we aren't relying on code generators as much.

@sigmundch
Copy link
Member Author

Agree


Removed this from the M8 milestone.
Added this to the Later milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed Oldschool-Milestone-Later label.

@dgrove
Copy link
Contributor

dgrove commented Aug 8, 2014

I don't think we need this for 1.6 .


Removed this from the 1.6 milestone.
Removed Priority-High label.
Added Priority-Medium label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed accepted labels Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

9 participants