Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error building editor in a locale different to English #11119

Closed
DartBot opened this issue Jun 6, 2013 · 9 comments
Closed

Error building editor in a locale different to English #11119

DartBot opened this issue Jun 6, 2013 · 9 comments
Assignees
Labels
area-infrastructure closed-not-planned Closed as we don't intend to take action on the reported issue

Comments

@DartBot
Copy link

DartBot commented Jun 6, 2013

This issue was originally filed by @irisindigo


What steps will reproduce the problem?

  1. When I run: ./tools/build.py --mode=release --arch=x64, I get an error.

What is the expected output? What do you see instead?

Expected output is:

...
build_rcp:

BUILD SUCCESSFUL
Total time: 2 minutes 57 seconds

Editor build successful
  TOUCH out/ReleaseX64/obj.target/editor.stamp
  TOUCH out/ReleaseX64/obj.target/most.stamp

Instead I get this ouput:

...
Building the editor
  config : linux, x64, release
  output : /dart/out/ReleaseX64/editor

cleaning /dart/out/ReleaseX64/editor

invoking build_rcp.xml with buildConfig = [linux, gtk, x86_64]

Cross-referencing dart:html...
Traceback (most recent call last):
  File "tools/create_editor.py", line 200, in <module>
    sys.exit(Main())
  File "tools/create_editor.py", line 169, in Main
    '-Dbuild.revision=' + utils.GetSVNRevision(),
TypeError: cannot concatenate 'str' and 'NoneType' objects
make: *** [out/ReleaseX64/editor/VERSION] Error 1
make: *** Se espera a que terminen otras tareas....
Analyzing libraries...
Generating documentation...
Warning: could not parse version: 0.1.2.0_user
Compiling client JavaScript...
Documentation complete -- documented 28 libraries, 883 types, and 45034 members.
BUILD FAILED

What version of the product are you using? On what operating system?

dart revison 23671
Ubuntu 13.04 64-bits
g++ (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
Python 2.7.4

Please provide any additional information below.

I attach a patch to solve this issue.


Attachment:
utils.py.patch (523 Bytes)

@kasperl
Copy link

kasperl commented Jun 10, 2013

Added Area-Build label.

@kasperl
Copy link

kasperl commented Jun 10, 2013

Added Triaged label.

@ricowind
Copy link
Contributor

Thanks for the report and the patch.
It does indeed solve the issue, we saw similar issues (and the same solution) last year when we submitted files with a non standard characters in the file names to the svn repo.
Could I convince you to sign this contributor agreement
https://developers.google.com/open-source/cla/individual

(yes, this is a very small and obvious patch, but anyway :-) )


cc @mkustermann.
Set owner to @ricowind.

@DartBot
Copy link
Author

DartBot commented Jun 15, 2013

This comment was originally written by @irisindigo


I've just signed it.
I wish it was OK.

Thanks.

@ricowind
Copy link
Contributor

Thanks a lot, I will land the patch

@ricowind
Copy link
Contributor

Committed in revision 24072 ( https://code.google.com/p/dart/source/detail?r=24072 )

Again, appreciate the patch.

Cheers,
Rico

@DartBot
Copy link
Author

DartBot commented Jun 17, 2013

This comment was originally written by @irisindigo


Thanks to you and Dart team for your amazing work and fast response.

@anders-sandholm
Copy link
Contributor

Removed Area-Build label.
Added Area-Infrastructure label.

@ricowind
Copy link
Contributor

ricowind commented Jun 2, 2015

Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Development

No branches or pull requests

5 participants