New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error building editor in a locale different to English #11119
Comments
Added Area-Build label. |
Added Triaged label. |
Thanks for the report and the patch. (yes, this is a very small and obvious patch, but anyway :-) ) cc @mkustermann. |
This comment was originally written by @irisindigo I've just signed it. Thanks. |
Thanks a lot, I will land the patch |
Committed in revision 24072 ( https://code.google.com/p/dart/source/detail?r=24072 ) Again, appreciate the patch. Cheers, |
This comment was originally written by @irisindigo Thanks to you and Dart team for your amazing work and fast response. |
Removed Area-Build label. |
Added WontFix label. |
This issue was originally filed by @irisindigo
What steps will reproduce the problem?
What is the expected output? What do you see instead?
Expected output is:
...
build_rcp:
BUILD SUCCESSFUL
Total time: 2 minutes 57 seconds
Editor build successful
TOUCH out/ReleaseX64/obj.target/editor.stamp
TOUCH out/ReleaseX64/obj.target/most.stamp
Instead I get this ouput:
...
Building the editor
config : linux, x64, release
output : /dart/out/ReleaseX64/editor
cleaning /dart/out/ReleaseX64/editor
invoking build_rcp.xml with buildConfig = [linux, gtk, x86_64]
Cross-referencing dart:html...
Traceback (most recent call last):
File "tools/create_editor.py", line 200, in <module>
sys.exit(Main())
File "tools/create_editor.py", line 169, in Main
'-Dbuild.revision=' + utils.GetSVNRevision(),
TypeError: cannot concatenate 'str' and 'NoneType' objects
make: *** [out/ReleaseX64/editor/VERSION] Error 1
make: *** Se espera a que terminen otras tareas....
Analyzing libraries...
Generating documentation...
Warning: could not parse version: 0.1.2.0_user
Compiling client JavaScript...
Documentation complete -- documented 28 libraries, 883 types, and 45034 members.
BUILD FAILED
What version of the product are you using? On what operating system?
dart revison 23671
Ubuntu 13.04 64-bits
g++ (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
Python 2.7.4
Please provide any additional information below.
I attach a patch to solve this issue.
Attachment:
utils.py.patch (523 Bytes)
The text was updated successfully, but these errors were encountered: