Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js should optimize String.charCodeAt #10631

Closed
peter-ahe-google opened this issue May 13, 2013 · 6 comments
Closed

dart2js should optimize String.charCodeAt #10631

peter-ahe-google opened this issue May 13, 2013 · 6 comments
Labels
web-dart2js

Comments

@peter-ahe-google
Copy link
Contributor

I think the scanner in dart2js is slow when self-hosting because dart2js doesn't optimize String.charCodeAt.
@kasperl
Copy link

kasperl commented May 23, 2013

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@rakudrama
Copy link
Member

cps_ir converts String.codeUnitAt to a bounds check and String.charCodeAt.
The bounds check can sometimes be elimiated.
No benchmarks made a statistically significant increase in performance.

@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @rakudrama @kasperl @peter-ahe-google