Set owner to @bwilkerson.
Added this to the M6 milestone.
Added Area-Analyzer, Triaged labels.

Removed this from the M6 milestone.
Added this to the M7 milestone.

M7 -> M8

Removed this from the M7 milestone.
Added this to the M8 milestone.

Removed this from the M8 milestone.
Added this to the Later milestone.

Although 'enum' is a reserved word, the bigger issue here is poor error recovery when encountering a statement at the top level.

Changed the title to: "Need better recovery for statements at the top level".

Added Analyzer-Recovery label.

Removed Type-Defect label.
Added Type-Enhancement label.

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

Removed Oldschool-Milestone-Later label.

This one is wild. It still produces a 11 errors/warnings! DartPad repro (warnings are truncated to first 5).

[error] Unexpected token '(' (/Users/srawlins/xy.dart, line 9, col 18)
[error] Expected a method, getter, setter or operator declaration (/Users/srawlins/xy.dart, line 9, col 18)
[error] Expected a method, getter, setter or operator declaration (/Users/srawlins/xy.dart, line 9, col 35)
[error] Unexpected token '[' (/Users/srawlins/xy.dart, line 9, col 35)
[error] The name '' is already defined (/Users/srawlins/xy.dart, line 9, col 35)
[error] The name '' is already defined (/Users/srawlins/xy.dart, line 9, col 43)
[error] Expected a method, getter, setter or operator declaration (/Users/srawlins/xy.dart, line 9, col 43)
[error] Unexpected token ']' (/Users/srawlins/xy.dart, line 9, col 43)
[warning] Undefined class 'allValues.forEach' (/Users/srawlins/xy.dart, line 9, col 1)
[warning] Undefined class 'result' (/Users/srawlins/xy.dart, line 9, col 29)
[warning] Undefined class 'id' (/Users/srawlins/xy.dart, line 9, col 41)
8 errors and 3 warnings found.

If you wrap the last line (the forEach statement) in a function, like void main() { ... }, you instead get 29 errors and 1 warning!!!

If you instead convert each case of the enum "variable" to enumx, you get 14 errors and 5 warnings!!!

So I think the 2 bugs in this issue are:

• Improve error recovery on statements that don't work top-level (in this case a method call on an object)
• Improve error recovery on keywords in method definitions, or for loop conditions, etc.

e.g. each of the three examples below produces similar crazy errors:

void main() {
  //for (enum in [1,2,3]) {
  //  print(enum);
  //}

  //for (in in [1,2,3]) {
  //  print(in);
  //}

  for (continue in [1,2,3]) {
    print(continue);
  }
}

3-year update:

• Original code now produces 8 errors (down from 11).
• Wrapping last statement in a function (like fn() => ...) reduces it to 4 errors, each appropriately about mis-using enum as an identifier.
• Replacing each enum identifier with enumx now produces 7 errors (down from 14).

The following code still produces too many errors:

void main() {
  // 4 errors.
  for (enum in [1,2,3]) {
    print(enum);
  }

  // 4 errors.
  for (in in [1,2,3]) {
    print(in);
  }

  // 5 errors.
  for (continue in [1,2,3]) {
    print(continue);
  }
}