Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mirrors] Small cleanups in the mirror API #10542

Closed
peter-ahe-google opened this issue May 8, 2013 · 2 comments
Closed

[mirrors] Small cleanups in the mirror API #10542

peter-ahe-google opened this issue May 8, 2013 · 2 comments
Assignees
Labels
area-library library-mirrors P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@peter-ahe-google
Copy link
Contributor

Please clean up the mirror API:

* Use List, not List<Object>

* Use Map<String, dynamic>, not Map<String, Object>

* Please add a space after commas.

@lrhn
Copy link
Member

lrhn commented Apr 30, 2014

Added Library-Mirrors label.

@peter-ahe-google peter-ahe-google self-assigned this Apr 30, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed accepted labels Feb 29, 2016
@srawlins
Copy link
Member

Mirrors API no longer includes List<Object>, nor Map<String, Object>. Code has been formatted with dartfmt, adding appropriate whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-library library-mirrors P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

4 participants