Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoint not getting triggered in Solar sample #10527

Closed
DartBot opened this issue May 8, 2013 · 8 comments
Closed

Breakpoint not getting triggered in Solar sample #10527

DartBot opened this issue May 8, 2013 · 8 comments
Assignees
Labels
area-vm closed-obsolete Closed as the reported issue is no longer relevant type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented May 8, 2013

This issue was originally filed by podivilov@google.com


Open Solar sample in editor and run. Wait for a few seconds then set a breakpoint in SolarSystem.drawBackground (solar.dart:132). Breakpoint is not triggered.

The behavior depends on timing. If you set the breakpoint fast enough after the sample is loaded, it will be triggered.

@DartBot
Copy link
Author

DartBot commented May 8, 2013

This comment was originally written by @mhausner


Can you run the VM with flags? If so, does this bug go away if you run the VM with:

--optimization_counter_threshold=-1

@DartBot
Copy link
Author

DartBot commented May 8, 2013

This comment was originally written by podivilov@google.com


Yes, with --optimization_counter_threshold=-1 everything works fine.

@anders-sandholm
Copy link
Contributor

Added Area-VM label.

@iposva-google
Copy link
Contributor

Removed Priority-Medium label.
Added Priority-Unassigned label.

@turnidge
Copy link
Contributor

Set owner to @turnidge.

@iposva-google
Copy link
Contributor

Added Accepted label.

@turnidge
Copy link
Contributor

I have verified that the bug still occurs, even after my recent fixes to debugging inlined functions. The function is clearly not being properly deoptimized in response to the new breakpoint. If I break in a sibling function single-step into the specified function, the breakpoint works after that point. So this is screwy.

I will investigate with some tracing code on and see what's going on.

@turnidge
Copy link
Contributor

turnidge commented Nov 6, 2013

We needed to deoptimize implicit closure functions. Fix is out for review.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@iposva-google iposva-google added the closed-obsolete Closed as the reported issue is no longer relevant label May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm closed-obsolete Closed as the reported issue is no longer relevant type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

5 participants