Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbols representing private names from different libraries should not be equal #10526

Closed
peter-ahe-google opened this issue May 8, 2013 · 9 comments
Closed

Symbols representing private names from different libraries should not be equal #10526

peter-ahe-google opened this issue May 8, 2013 · 9 comments
Assignees
@peter-ahe-google
Labels
closed-obsolete Closed as the reported issue is no longer relevant library-mirrors P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@peter-ahe-google
Copy link
Contributor

According to Lasse:

// Have this code available:

class _ {
  const _();
  noSuchMethod(i) => i.memberName;
}
const $ = const _();

// Then do:

var symbol1 = $._foo;

// and in another library

var symbol2 = $._foo;

// somewhere

print(symbol1 == symbol2); // true or false?

Currently the VM prints false and dart2js prints true.
@peter-ahe-google
Copy link
Contributor Author

The VM is correct, this is a bug in dart2js.

cc @lrhn.

@kasperl
Copy link

kasperl commented May 23, 2013

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@peter-ahe-google
Copy link
Contributor Author

Added Library-Mirrors label.

@peter-ahe-google
Copy link
Contributor Author

Marked this as blocking #6490.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@peter-ahe-google peter-ahe-google self-assigned this Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Mar 3, 2018
@matanlurey
Copy link
Contributor

Mirrors is no longer supported in Dart2JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peter-ahe-google peter-ahe-google

Labels
closed-obsolete Closed as the reported issue is no longer relevant library-mirrors P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @matanlurey @kasperl @peter-ahe-google