Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source library mirrors should provide access to compilation units of a library. #10370

Closed
peter-ahe-google opened this issue May 1, 2013 · 6 comments
Closed

Source library mirrors should provide access to compilation units of a library. #10370

peter-ahe-google opened this issue May 1, 2013 · 6 comments
Assignees
@johnniwinther
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue library-mirrors web-dart2js

Comments

@peter-ahe-google
Copy link
Contributor

It is possible that it doesn't make sense to expose compilation units in dart:mirrors, but the source mirrors should provide this abstraction.

For example:

abstract class LibrarySourceMirror extends LibraryMirror {
  final Map<Uri, CompilationUnitMirror> compilationUnits;
}
@kasperl
Copy link

kasperl commented May 23, 2013

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@sigmundch sigmundch added the closed-not-planned Closed as we don't intend to take action on the reported issue label Dec 11, 2015
@sigmundch
Copy link
Member

Now that dartdoc was moved away from the source-mirrors library and is using the analyzer parser directly, we will deprecate the source-mirrors library. So we are not planning to add this feature anymore.

@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
closed-not-planned Closed as we don't intend to take action on the reported issue library-mirrors web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @sigmundch @kasperl @peter-ahe-google @karlklose @johnniwinther