Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print is not working in dart2js web workers #10224

Closed
peter-ahe-google opened this issue Apr 26, 2013 · 14 comments
Closed

print is not working in dart2js web workers #10224

peter-ahe-google opened this issue Apr 26, 2013 · 14 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant web-dart2js

Comments

@peter-ahe-google
Copy link
Contributor

console.log doesn't work in web workers, consequently, print does not work.

It seems like Dartium has implemented print in non-DOM isolates by sending a message back to the root isolate. We should be able to do something similar in dart2js.

@kasperl
Copy link

kasperl commented May 23, 2013

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@yjbanov
Copy link

yjbanov commented Jan 6, 2015

Can we revisit this issue please?

console.log works in web workers. I checked Chrome and Firefox. Safari doesn't choke on it but neither does it print anything to the log (or maybe I don't know where to look for worker messages). Not sure about IE.


Added C9 label.

@yjbanov
Copy link

yjbanov commented Jan 6, 2015

Just checked with IE11. console.log works just fine on the web worker.

@floitschG
Copy link
Contributor

I just tried locally, and print goes to console.log for me.

Do you have a repro?


Added CannotReproduce label.

@yjbanov
Copy link

yjbanov commented Jan 26, 2015

Last time I checked was <1 month ago, and Dartium would throw if you tried to print from an isolate. Given the expectation that Dartium and dart2js behave the same I'd say this bug is not yet fixed. I'm ok if we want it to be a separate issue, but it is an issue and a big one for anyone trying to use isolates.

@yjbanov
Copy link

yjbanov commented Jan 26, 2015

Oh, if you do decide to create a separate issue, please assign C9 label to it. Thanks.

@DartBot
Copy link

DartBot commented Jan 26, 2015

This comment was originally written by matan...@google.com


I tried this today, and Dartium still throws.

It is possible that the dart2js version compiles OK, but that makes debugging your isolates and using Dartium hard without using zones and message passing ... for basic print(s).

@yjbanov
Copy link

yjbanov commented Jan 26, 2015

Added Triaged label.

@floitschG
Copy link
Contributor

Calm down...

A bug that has "dart2js" in the title and the description, talks about web workers (only used in dart2js), is assigned to Area-Dart2js and where you mention Firefox, Safari and IE is about dart2js.
So yes, this bug can be closed (unless you have a repro).

Given that this bug was that strongly marked as dart2js I didn't even test Dartium...

#­9: Yes. If you see a bug that is about dart2js and you see similar behavior in the VM or Dartium please file a new bug, or look if one already exists.
In this case there are already two: issue #14080 and issue #16565

I will mark it as c9 and ping the people that could fix them.


Added AssumedStale label.

@alan-knight
Copy link
Contributor

I also opened 22163 for the issue of not printing from Dartium. Will link them.

@peter-ahe-google peter-ahe-google added Type-Defect web-dart2js closed-obsolete Closed as the reported issue is no longer relevant labels Jan 27, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant web-dart2js
Projects
None yet
Development

No branches or pull requests

6 participants