Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent changes cause keyboard shortcut not working on github #118

Closed
hrzhu opened this issue Dec 22, 2015 · 8 comments
Closed

recent changes cause keyboard shortcut not working on github #118

hrzhu opened this issue Dec 22, 2015 · 8 comments

Comments

@hrzhu
Copy link

hrzhu commented Dec 22, 2015

steps to reproduce:
go to https://github.com/5digits/dactyl, type o, nothing happens, O works. I don't know which specific commit introduce this but reverting to a19a865 the problem is gone.

@prmtl
Copy link
Contributor

prmtl commented Dec 22, 2015

+1 here. On the newest build keys like 't', 'o' do not work on Github. They also do not work on Google as search input is always having focus.

@jonlorusso
Copy link

+1

Not sure if this is related or a separate issue:
type 't' (for :tabnew), try typing 'j'. does not work. Capital J does work however. Very odd.

Also, in slack (for instance), <Escape> does not exit -- INSERT -- mode. Again, not sure if this is related or a fully separate issue. Edit: This is a separate issue, described here.

@timokau
Copy link

timokau commented Dec 23, 2015

Same problem with reddit (with Reddit Enhancement Suite)
Probably because reddit and github define their own keyboard shortcuts and pentadactyl doesn't intercept them correctly.

@ghost
Copy link

ghost commented Dec 23, 2015

@jonlorusso you have a binding for jj -> escape, right? #116

@jonlorusso
Copy link

@rbtwrrr

Close:

cmap jk <Escape>

I'll strikeout that section of my comment above.

@jbylsma
Copy link

jbylsma commented Dec 26, 2015

I believe these issues are all from some PassThrough changes in 28fe4af. I created a pull request #124 that I think should fix it. Can you please test?

@wasamasa
Copy link

wasamasa commented Jan 1, 2016

@jbylsma Thanks, your changes fixed it for me.

@jbylsma
Copy link

jbylsma commented Jan 9, 2016

This was fixed with 4904fb5 and can be closed.

@hrzhu hrzhu closed this as completed Jan 10, 2016
prmtl added a commit to prmtl/dactyl that referenced this issue Jan 18, 2016
* 'master' of github.com:5digits/dactyl: (29 commits)
  Add descriptions
  Fix :help completion.
  Add tabattachto and tabdetachfrom
  Add tab{next,previous}visible to jump over folds
  Fix applying to parent fold
  Fix :command listings.
  Fix charset completion.
  Fix :listkeys completion.
  Fix JAR file completion.
  Fix :cookies action completion.
  Fix command related JavaScript completers.
  Add tabbartoggle, tabclosechildren, tabclosewithchildren
  Fix to handle multiple arguments and allow completion
  Fix 'ga' not properly closing parent fold
  Allow to pass options for commands
  Fix typo
  Add a contrib directory to plugins/.
  Add treestyletabs.js
  Prevent certain sites from overriding mappings. Closes issue 5digits#118.
  Update curl plugin.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants