cssmin - Project Hosting on Google Code

Earlier this year Sep 01, 2009 issue 7 (Order the properties for a better GZip compression) reported by daniel.kobler - Hi, What would be very nice is to return the css with the properties ordered in alphbetical order. This will help to reduce the size of the file once gzipped. Best regards Daniel Hi, What would be very nice is to return the css with the properties ordered in alphbetical order. This will help to reduce the size of the file once gzipped. Best regards Daniel May 13, 2009 issue 6 (preserve-urls option doesn't retransform the urls correctly) reported by jassem.shahrani - What steps will reproduce the problem? 1. use a url() expression in your css, say, a background style (ex. background:url(sprite.png); 2. use the preserve-urls option 3. minify What is the expected output? What do you see instead? - Expected for background portion: background:url(sprite.png); - Instead seeing: background:url(YzNCeWFYUmxMbkJ1Wnc9PQ==); What version of the product are you using? On what operating system? 1.0.1.b3 (2008-10-02) on Windows and Linux Please provide any additional information below. FIX FOUND: ---------- The Problem: ------------ seems to be a typo - basically the cssmin process for preserving urls is to base64_encode them, then perform minification, then base64_decode those urls. BUT, when it performs the decode step, it actually performs another encode... the errant line of code in the version noted above is line 72: $css = preg_replace_callback("/url\s\((.)\)/siU", "cssmin_encode_url", $css); The Solution: ------------- Line 72 should be: (notice the precise name of the callback function) $css = preg_replace_callback("/url\s\((.)\)/siU", "cssmin_decode_url", $css); That resolves the problem. What steps will reproduce the problem? 1. use a url() expression in your css, say, a background style (ex. background:url(sprite.png); 2. use the preserve-urls option 3. minify What is the expected output? What do you see instead? - Expected for background portion: background:url(sprite.png); - Instead seeing: background:url(YzNCeWFYUmxMbkJ1Wnc9PQ==); What version of the product are you using? On what operating system? 1.0.1.b3 (2008-10-02) on Windows and Linux Please provide any additional information below. FIX FOUND: ---------- The Problem: ------------ seems to be a typo - basically the cssmin process for preserving urls is to base64_encode them, then perform minification, then base64_decode those urls. BUT, when it performs the decode step, it actually performs another encode... the errant line of code in the version noted above is line 72: $css = preg_replace_callback("/url\s\((.)\)/siU", "cssmin_encode_url", $css); The Solution: ------------- Line 72 should be: (notice the precise name of the callback function) $css = preg_replace_callback("/url\s\((.)\)/siU", "cssmin_decode_url", $css); That resolves the problem. Apr 15, 2009 issue 5 (Incorrect removal of spaces following a quoted comma) Status changed by joe.scylla - Status: Duplicate Status: Duplicate Apr 15, 2009 issue 3 (Incorrect removal of all spaces following ']' character) Status changed by joe.scylla - Status: Accepted Status: Accepted Apr 15, 2009 issue 4 (Incorrect removal of spaces following a quoted comma) Status changed by joe.scylla - Status: Accepted Status: Accepted Apr 02, 2009 issue 4 (Incorrect removal of spaces following a quoted comma) commented on by alexan...@mindey.se - Perhaps you can use all or parts of the css minifier in Minify. I think this lighteight approach is better than the larger minify, however their regular expressions may be better. Copy with pride. http://code.google.com/p/minify/source/browse/trunk/min/lib/Minify/CSS/Compressor.php Perhaps you can use all or parts of the css minifier in Minify. I think this lighteight approach is better than the larger minify, however their regular expressions may be better. Copy with pride. http://code.google.com/p/minify/source/browse/trunk/min/lib/Minify/CSS/Compressor.php Apr 02, 2009 issue 5 (Incorrect removal of spaces following a quoted comma) commented on by alexan...@mindey.se - Sorry for the duplicate. Sorry for the duplicate. Apr 02, 2009 issue 5 (Incorrect removal of spaces following a quoted comma) reported by alexan...@mindey.se - What steps will reproduce the problem? 1. INPUT: ul.comma > li:not(:only-child):after{content:", ";} 2. Minify 3. OUTPUT: ul.comma > li:not(:only-child):after{content:",";} What is the expected output? What do you see instead? ul.comma > li:not(:only-child):after{content:", ";} See above. What version of the product are you using? On what operating system? 1.0 OS X 10.5 Please provide any additional information below. What steps will reproduce the problem? 1. INPUT: ul.comma > li:not(:only-child):after{content:", ";} 2. Minify 3. OUTPUT: ul.comma > li:not(:only-child):after{content:",";} What is the expected output? What do you see instead? ul.comma > li:not(:only-child):after{content:", ";} See above. What version of the product are you using? On what operating system? 1.0 OS X 10.5 Please provide any additional information below. Apr 02, 2009 issue 4 (Incorrect removal of spaces following a quoted comma) reported by alexan...@mindey.se - What steps will reproduce the problem? 1. INPUT: ul.comma > li:not(:only-child):after{content:", ";} 2. Minify 3. OUTPUT: ul.comma > li:not(:only-child):after{content:",";} What is the expected output? What do you see instead? ul.comma > li:not(:only-child):after{content:", ";} See above. What version of the product are you using? On what operating system? 1.0 OS X 10.5 Please provide any additional information below. What steps will reproduce the problem? 1. INPUT: ul.comma > li:not(:only-child):after{content:", ";} 2. Minify 3. OUTPUT: ul.comma > li:not(:only-child):after{content:",";} What is the expected output? What do you see instead? ul.comma > li:not(:only-child):after{content:", ";} See above. What version of the product are you using? On what operating system? 1.0 OS X 10.5 Please provide any additional information below. Jan 06, 2009 issue 3 (Incorrect removal of all spaces following ']' character) reported by jmertic - What steps will reproduce the problem? 1. Create a CSS file with a rule like the following: td[scope=row] p { ... } 2. Run css thru cssmin What is the expected output? What do you see instead? Expected: td[scope=row] p{ ... } Actual: td[scope=row]p{ ... } The actual result breaks the CSS rule ( tested in FF 3 ) What version of the product are you using? On what operating system? 1.0.1.b3 (2008-10-02) Please provide any additional information below. Here's a diff of the fix ( the revision numbers correspond to my local SVN repo ): Index: cssmin.php =================================================================== --- cssmin.php (revision 42961) +++ cssmin.php (working copy) @@ -59,7 +59,7 @@ (root):cssmin(class):minify(function) // Replace multiple to single space $css = preg_replace("/\s\s+/", " ", $css); // Remove unneeded spaces - $css = preg_replace("/\s({\|}\|\[\|\]\|=\|~\|\+\|>\|\\|\|;\|:\|,)\s/", "$1", $css); + $css = preg_replace("/\s({\|}\|\[\|=\|~\|\+\|>\|\\|\|;\|:\|,)\s/", "$1", $css); if (in_array("remove-last-semicolon", $options)) { // Removes the last semicolon of every style definition What steps will reproduce the problem? 1. Create a CSS file with a rule like the following: td[scope=row] p { ... } 2. Run css thru cssmin What is the expected output? What do you see instead? Expected: td[scope=row] p{ ... } Actual: td[scope=row]p{ ... } The actual result breaks the CSS rule ( tested in FF 3 ) What version of the product are you using? On what operating system? 1.0.1.b3 (2008-10-02) Please provide any additional information below. Here's a diff of the fix ( the revision numbers correspond to my local SVN repo ): Index: cssmin.php =================================================================== --- cssmin.php (revision 42961) +++ cssmin.php (working copy) @@ -59,7 +59,7 @@ (root):cssmin(class):minify(function) // Replace multiple to single space $css = preg_replace("/\s\s+/", " ", $css); // Remove unneeded spaces - $css = preg_replace("/\s({\|}\|\[\|\]\|=\|~\|\+\|>\|\\|\|;\|:\|,)\s/", "$1", $css); + $css = preg_replace("/\s({\|}\|\[\|=\|~\|\+\|>\|\\|\|;\|:\|,)\s/", "$1", $css); if (in_array("remove-last-semicolon", $options)) { // Removes the last semicolon of every style definition Older Oct 02, 2008 issue 2 (remove ; before }) Status changed by joe.scylla - Version 1.0.1.b3 removes now the last semicolon of a style definition. To preserve the last semicolon you have to deactivate the default option "remove-last-semicolon" with a empty option string. Status: Fixed Version 1.0.1.b3 removes now the last semicolon of a style definition. To preserve the last semicolon you have to deactivate the default option "remove-last-semicolon" with a empty option string. Status: Fixed Oct 02, 2008 r5 (+ Option to remove the last semicolon of every style definit...) committed by joe.scylla - + Option to remove the last semicolon of every style definitions + Option to remove the last semicolon of every style definitions Sep 05, 2008 issue 2 (remove ; before }) changed by joe.scylla - I will include a option in the next release that these semi-colon can get removed (or a option to preserve them) depending on what behaviour is the default. Summary: remove ; before } Status: Accepted Owner: joe.scylla Labels: Type-Enhancement Priority-Low −Type-Defect −Priority-Medium I will include a option in the next release that these semi-colon can get removed (or a option to preserve them) depending on what behaviour is the default. Summary: remove ; before } Status: Accepted Owner: joe.scylla Labels: Type-Enhancement Priority-Low −Type-Defect −Priority-Medium Aug 31, 2008 issue 2 ([Enhancement] remove ; before }) reported by dpobel - ; just before } are not necessary and without them the stylesheet is still valid. ; just before } are not necessary and without them the stylesheet is still valid. Aug 15, 2008 r4 ( Version 1.0.1.b2 + New method cssmin::toArray() - convert...) committed by joe.scylla - Version 1.0.1.b2 + New method cssmin::toArray() - convert a stylesheet definition to a array structure + New method cssmin::toString() - convert a array structure to a stylesheet definition + New helper functions cssmin_array_clean() and cssmin_array_is_assoc(). ^ Moved private functions to helper functions (now named cssmin_decode_url() and cssmin_encode_url()) Version 1.0.1.b2 + New method cssmin::toArray() - convert a stylesheet definition to a array structure + New method cssmin::toString() - convert a array structure to a stylesheet definition + New helper functions cssmin_array_clean() and cssmin_array_is_assoc(). ^ Moved private functions to helper functions (now named cssmin_decode_url() and cssmin_encode_url()) Aug 07, 2008 issue 1 (Regular expression are erroneous) changed by joe.scylla - Thanks for you bug report. I have to admit, that regular expressions are not one of my strenghts ;). This bug is fixed in the version 1.0.1.b1 which is marked as beta because i did a complete rewrite of the minify process. So this version requires some testing to get stable. Any comments on the new version are apriciated. Status: Fixed Labels: Component-Logic Thanks for you bug report. I have to admit, that regular expressions are not one of my strenghts ;). This bug is fixed in the version 1.0.1.b1 which is marked as beta because i did a complete rewrite of the minify process. So this version requires some testing to get stable. Any comments on the new version are apriciated. Status: Fixed Labels: Component-Logic Aug 07, 2008 r3 (^ Complete rewrite of the minify process # Fixed issue #1: ...) committed by joe.scylla - ^ Complete rewrite of the minify process # Fixed issue #1 : Regular expression are erroneous + Support minify of Patterns like: E > F, E + F, E[attrib="value"], E[lang\|="en"] + Option to preserve url()-expressions like: background: url(url/to/image.ext) ^ Complete rewrite of the minify process # Fixed issue #1 : Regular expression are erroneous + Support minify of Patterns like: E > F, E + F, E[attrib="value"], E[lang\|="en"] + Option to preserve url()-expressions like: background: url(url/to/image.ext)

issue 6 (preserve-urls option doesn't retransform the urls correctly) reported by jassem.shahrani - What steps will reproduce the problem? 1. use a url() expression in your css, say, a background style (ex. background:url(sprite.png); 2. use the preserve-urls option 3. minify What is the expected output? What do you see instead? - Expected for background portion: background:url(sprite.png); - Instead seeing: background:url(YzNCeWFYUmxMbkJ1Wnc9PQ==); What version of the product are you using? On what operating system? 1.0.1.b3 (2008-10-02) on Windows and Linux Please provide any additional information below. FIX FOUND: ---------- The Problem: ------------ seems to be a typo - basically the cssmin process for preserving urls is to base64_encode them, then perform minification, then base64_decode those urls. BUT, when it performs the decode step, it actually performs another encode... the errant line of code in the version noted above is line 72: $css = preg_replace_callback("/url\s*$(.*)$/siU", "cssmin_encode_url", $css); The Solution: ------------- Line 72 should be: (notice the precise name of the callback function) $css = preg_replace_callback("/url\s*$(.*)$/siU", "cssmin_decode_url", $css); That resolves the problem.

What steps will reproduce the problem? 1. use a url() expression in your css, say, a background style (ex. background:url(sprite.png); 2. use the preserve-urls option 3. minify What is the expected output? What do you see instead? - Expected for background portion: background:url(sprite.png); - Instead seeing: background:url(YzNCeWFYUmxMbkJ1Wnc9PQ==); What version of the product are you using? On what operating system? 1.0.1.b3 (2008-10-02) on Windows and Linux Please provide any additional information below. FIX FOUND: ---------- The Problem: ------------ seems to be a typo - basically the cssmin process for preserving urls is to base64_encode them, then perform minification, then base64_decode those urls. BUT, when it performs the decode step, it actually performs another encode... the errant line of code in the version noted above is line 72: $css = preg_replace_callback("/url\s*$(.*)$/siU", "cssmin_encode_url", $css); The Solution: ------------- Line 72 should be: (notice the precise name of the callback function) $css = preg_replace_callback("/url\s*$(.*)$/siU", "cssmin_decode_url", $css); That resolves the problem.

Earlier this year

Older