Issue 4 - compactcms - web server 404 for js and css as the generated HTML is wrong.

Issue 4:	web server 404 for js and css as the generated HTML is wrong.
	1 person starred this issue and may be notified of changes.	Back to list

Status:	WontFix
Owner:	----
Closed:	Nov 29
Component-Logic
Priority-Low

Reported by ger.hobbelt, Sep 08, 2009

See attached diff (same as for ID #3, sorry, I was wrong: this patch 100%
fixes the issue: the original HTML mentioned 3 comma-separated files (both
for JS and CSS, btw) in a single HTML ref which is submitted to the server
as a single filepath -- which consequently b0rks with a 'cannot find file'.

The attached patch fixes this.

one-mootools-only.diff
1.3 KB Download

Comment 1 by atgroesb...@gmail.com, Sep 11, 2009

(No comment was entered for this change.)

Status: Accepted

Comment 2 by ger.hobbelt, Sep 13, 2009

following comment on the undesirability of making admin part dependent on user-site
mootools, the patch has been adjusted accordingly, as this issue of incorrect
generated HTML remains.

patch will now ensure the admin-level mootools copy is used.

js-and-css-loading-failure.diff
1.5 KB Download

Comment 3 by ger.hobbelt, Sep 14, 2009

patch adjusted to work with r.65

(please note that this has nothing to do with the mootools issue; see the patch: it's
about comma-separated filenames in a single HTML href which AFACT is illegal HTML;
anyway, FF3 and Minefield (Firefox for Win64) barf on the generated HTML. That's what
this patch was/is all about.

ccms-multiple-css-and-js-in-single-html-ref.diff
1.3 KB Download

Comment 4 by eckostylez, Nov 07, 2009

Or you can do this:
Line 341 in /admin/index.php:
Find:

<script type="text/javascript"
src="includes/js/mootools.js,common.js,editorwindow.js" charset="utf-8"></script>
<link rel="stylesheet" type="text/css"
href="img/styles/base.css,layout.css,editor.css" />

Replace with:

<script type="text/javascript" src="includes/js/mootools.js" charset="utf-8"></script>
<script type="text/javascript" src="includes/js/common.js" charset="utf-8"></script>
<script type="text/javascript" src="includes/js/editorwindow.js"
charset="utf-8"></script>
<link rel="stylesheet" type="text/css" href="img/styles/base.css" />
<link rel="stylesheet" type="text/css" href="img/styles/layout.css" />
<link rel="stylesheet" type="text/css" href="img/styles/editor.css" />


And that should fix any problems with non-valid HTML tags and attributes.

Comment 5 by atgroesb...@gmail.com, Nov 29, 2009

- Closing issue
It is in the core of CompactCMS to archive and cache both JS and CSS. By separating
these tags, this functionality is lost. If for whatever reason one requires caching
to be disabled, the given work-around (e.g. the separation of the script and link
tags) will fix this "issue".

Status: WontFix
Labels: -Type-Defect -Priority-Medium Component-Logic Priority-Low