Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support binary streams on Python 3 #21

Open
birkenfeld opened this issue Oct 14, 2014 · 1 comment
Open

Support binary streams on Python 3 #21

birkenfeld opened this issue Oct 14, 2014 · 1 comment
Labels
feature-request unicode

Comments

@birkenfeld
Copy link

On Python 3, it is impossible to use colorama with a binary stream, such as sys.stdout.buffer, but it is necessary to use this if you need precise control over the encoding of your output.

In any case, ANSI escapes are by nature binary insertions in a binary stream, so it makes sense to support this mode.
wiggin15 pushed a commit to wiggin15/colorama that referenced this issue Oct 31, 2014
Fix tartley#21 by converting all text to binary in case of binary stream
5b245e5
@wiggin15
Copy link
Collaborator

I wrote a fix and pushed to my local repository for now (see reference above). I'm not sure I like this fix, though, so I won't merge it yet.

wiggin15 pushed a commit to wiggin15/colorama that referenced this issue Nov 3, 2014
Fix tartley#21 by converting all text to binary in case of binary stream
0b2ab1a
@wiggin15 wiggin15 mentioned this issue Nov 5, 2014
Closed
@jackwilsdon jackwilsdon mentioned this issue Dec 23, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request unicode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tartley @birkenfeld @wiggin15