Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

Add Included classes in renaming #1

Closed
wants to merge 2 commits into from
Closed

Add Included classes in renaming #1

wants to merge 2 commits into from

Conversation

twpayne
Copy link

@twpayne twpayne commented Apr 30, 2014

This PR adds an option to force classes to be included in the renaming map.

The background and motivation for this patch were discussed on the closure-stylesheets-discuess email list.

Great to see Closure Stylesheets on GitHub!

@natedub
Copy link

natedub commented Apr 30, 2014

Interesting, I hadn't realized this would be an issue with class renaming. How are you extracting all the possible class names from the JS? Is there something included in the JS compiler for that or did you write a custom pass?

@twpayne
Copy link
Author

twpayne commented May 1, 2014

My application only has a few distinct controls, so the class names are effectively hardcoded in the source code.

iflan pushed a commit that referenced this pull request Feb 17, 2015
This CL is refactor work. There is no behavior change.

The only change in codebase is replacing explicit usage of
StringBuilder in end code with public methods with the same
implementation.

It enables consistent access to output buffer from different printers
in various sources, this decoupling enables further work on gss
compiler.

Code Design:

It creates an abstract class CodePrinter to hold the output buffer and
related APIs to r/w the buffer, subclasses could only alter the buffer
through these APIs; this layer provides a complete control over the
pointers in output buffer.

All printers are extended from this base class and remove its own
output buffer.

CL also includes changes and cleanups for direct usage of output
buffer outside the css compiler itself.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=86326296
@twpayne twpayne closed this Jul 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants