Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate variable name in goog.ui.popupmenu annotaions. (57bdfe0) #457

Closed
gumm opened this issue Apr 26, 2015 · 3 comments
Closed

Duplicate variable name in goog.ui.popupmenu annotaions. (57bdfe0) #457

gumm opened this issue Apr 26, 2015 · 3 comments

Comments

@gumm
Copy link

gumm commented Apr 26, 2015

The Compiler warns with the following when using goog.ui.popupmenu:
This is for the library as per commit number 57bdfe0 of Apr 25, 2015

closure-library/closure/goog/ui/popupmenu.js:573: WARNING - Bad type annotation. duplicate variable name "e"

  • @param {!goog.events.BrowserEvent} e The browser event.
    ^

closure-library/closure/goog/ui/popupmenu.js:593: WARNING - Bad type annotation. duplicate variable name "e"

  • @param {?goog.events.BrowserEvent} e The browser event.
    ^
@koto
Copy link
Member

koto commented Apr 28, 2015

This seems to be because of merging error in the given file:

/**
 * Handles a KEYDOWN browser event on one of the popup targets.
 * @param {goog.events.BrowserEvent} e The browser event.
 * @param {!goog.events.BrowserEvent} e The browser event.
 * @private
 */

The @param line was modified recently in the internal version.

@koto
Copy link
Member

koto commented Apr 28, 2015

This commit is a culprit: 39651a9

koto added a commit to koto/closure-library that referenced this issue Apr 28, 2015
@concavelenz
Copy link
Contributor

verify fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants