I don't think anyone uses depswriter.py within Google, so (if I remember correctly) we want to try and get rid of it, but I don't know if we have any suitable replacement for open-source users.

So basically this is a no-op for open source then?

At least for the moment, yes :(

I thought I updated this. Are you sure you are using the latest?
On Nov 27, 2014 6:44 AM, "pstjvn" notifications@github.com wrote:

depswriter.py does not produce the new dependency format needed for the
module support, thus it prevent the usage of modules in third party code.

Please push the needed updates to the open source repo.

Thanks.

—
Reply to this email directly or view it on GitHub
#382.

peterj | Jobs: 0 | @work:~/Documents/Projects/closure/library
$ git pull
Already up-to-date.

peterj | Jobs: 0 | @work:~/Documents/Projects/closure/apps/material
$ python ../../library/closure/bin/build/depswriter.py --root_with_prefix="js ../../../apps/mobiletv/js"
// This file was autogenerated by ../../library/closure/bin/build/depswriter.py.
// Please do not edit.
goog.addDependency('../../../apps/mobiletv/js/app.js', ['app'], ['material.app']);
goog.addDependency('../../../apps/mobiletv/js/m60.js', ['m60.weather'], ['goog.Promise', 'goog.json', 'goog.labs.net.xhr']);
goog.addDependency('../../../apps/mobiletv/js/matetial.js', ['material.app'], ['pstj.material.decorator']);

I am not 100% sure what the new format should be, but this looks like it is not (missing last argument?)

drat, it was missed, I was thinking about something else. Thanks for
reporting this, the fix is trivial and I have it out for review. If you
want to patch it locally, replace _GetDepsLine with:

def _GetDepsLine(path, js_source):
"""Get a deps.js file string for a source."""

provides = sorted(js_source.provides)
requires = sorted(js_source.requires)
module = 'true' if js_source else 'false'

return 'goog.addDependency('%s', %s, %s, %s);\n' % (
path, provides, requires, module)

On Thu, Dec 4, 2014 at 2:39 PM, pstjvn notifications@github.com wrote:

peterj | Jobs: 0 | @work:~/Documents/Projects/closure/library
$ git pull
Already up-to-date.

peterj | Jobs: 0 | @work:~/Documents/Projects/closure/apps/material
$ python ../../library/closure/bin/build/depswriter.py --root_with_prefix="js ../../../apps/mobiletv/js"
// This file was autogenerated by ../../library/closure/bin/build/depswriter.py.
// Please do not edit.
goog.addDependency('../../../apps/mobiletv/js/app.js', ['app'], ['material.app']);
goog.addDependency('../../../apps/mobiletv/js/m60.js', ['m60.weather'], ['goog.Promise', 'goog.json', 'goog.labs.net.xhr']);
goog.addDependency('../../../apps/mobiletv/js/matetial.js', ['material.app'], ['pstj.material.decorator']);

I am not 100% sure what the new format should be, but this looks like it
is not (missing last argument?)

—
Reply to this email directly or view it on GitHub
#382 (comment)
.

Thank you