Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CD playback support #701

Closed
Clementine-Issue-Importer opened this issue Dec 6, 2013 · 0 comments
Closed

CD playback support #701

Clementine-Issue-Importer opened this issue Dec 6, 2013 · 0 comments

Comments

@Clementine-Issue-Importer

From tomprendergast2 on September 05, 2010 22:09:39

There is currently no CD support in Clementine, so I would like to make a request for it to included in future releases.

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=701

@Clementine-Issue-Importer
Copy link
Author

From john.maguire on September 05, 2010 14:26:40

Summary: CD playback support
Labels: -Type-Defect -Priority-Medium Type-Enhancement Priority-Low Component-Sound

@Clementine-Issue-Importer
Copy link
Author

From davidsansome on October 18, 2010 10:06:05

Issue 899 has been merged into this issue.

@Clementine-Issue-Importer
Copy link
Author

From himynameiszacHandiamapirate on December 31, 2010 08:50:29

Maybe it could show up under "devices", or something? Rename Devices to Media?

@Clementine-Issue-Importer
Copy link
Author

From jkflying on January 23, 2011 23:41:34

This is the only issue stopping Clementine from being used as a primary media center.

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on March 06, 2011 15:16:31

Amarok just seems to get worse not better so it would be a good opportunity to steal their thunder

@Clementine-Issue-Importer
Copy link
Author

From tdockery97 on March 06, 2011 17:50:32

I think CD support should be looked at as a necessary addition

@Clementine-Issue-Importer
Copy link
Author

From dreamsofubuntu on March 06, 2011 18:21:09

Agreed CD support should be added =]

@Clementine-Issue-Importer
Copy link
Author

From steveh@idnetfreemail.co.uk on March 07, 2011 01:14:31

This would be a very useful addition for me. Clementine is my favourite music player, and CD support would mean I could lose one more unnecessary player from my system.

@Clementine-Issue-Importer
Copy link
Author

From cpatrick008 on March 07, 2011 10:37:57

agreed CD support should be added

@Clementine-Issue-Importer
Copy link
Author

From transitman on March 13, 2011 17:27:54

I agree, CD support should be added.

@Clementine-Issue-Importer
Copy link
Author

From john.maguire on March 17, 2011 08:31:28

Issue 1495 has been merged into this issue.

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on March 18, 2011 09:04:11

Can I make a request to move the priority from low to medium?

@Clementine-Issue-Importer
Copy link
Author

From keirangtp on March 19, 2011 05:56:21

You can but what actually matters to us is:

  • the amount of people who want the feature
  • the amount of people for whom an issue crashes Clementine, breaks their Clementine's DB etc.

When it comes to people wanting a feature, CD playback is not so far from the top so I'm sure we'll tackle this at some point.

@Clementine-Issue-Importer
Copy link
Author

From rec9140 on March 20, 2011 03:43:24

Any media player should have CD playback. I would rate this a high priority over and above support of any external players which I did not compile support for.

Since amarok tanked, heres the chance to replace it, and thus CD support is a must have.

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on March 20, 2011 03:54:50

I would like to make one observation. Amarok 1.4.10 used to work perfectly with CDs and I don't really understand why Clementine, which is based on that release didn't have this functionality in from day one.

@Clementine-Issue-Importer
Copy link
Author

From Nickollai on March 20, 2011 11:25:10

I think this feature is not important: CDs are obsolete, just safe OD content as flac files to your HDD/SDD/flash.

@Clementine-Issue-Importer
Copy link
Author

From arnaud.bienner on March 20, 2011 11:44:12

I agree with comment 14: Clementine is a music player, so playing CD is important (even if CDs are not very use today).
I changed the priority and, maybe, will try to implement this issue if I have enough time.
About comment 15: Clementine is inpired by Amarok 1.4, but has been rewritten using Qt4, and don't share lot of code with Amarok. So that's why this feature need to be rewritten.

Status: Accepted
Owner: arnaud.bienner
Labels: -Priority-Low Priority-Medium

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on April 23, 2011 16:09:06

I would also like to point out that Windows Media Player is incredibly easy to use, especially when you want to rip a CD. Amarok is a dog by comparison, Clementine would be the number one choice if it was as user friendly as WM Player.

@Clementine-Issue-Importer
Copy link
Author

From davidsansome on May 01, 2011 08:23:24

Issue 1837 has been merged into this issue.

@Clementine-Issue-Importer
Copy link
Author

From larssonjonas1 on May 05, 2011 12:42:49

I just found out about Clementine. I really like Amarok with folder view but Amarok isn't stable all the time especially in a Gnome DE. Clementine is quick and stable, and I think I'm in love with it ;)

pls add CD support (even if CDs are obsolete it would be useful for many still)

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on May 09, 2011 15:19:28

I am asking for two things, firstly the ability to play CDs and secondly to able to rip CDs easily. If that was done then Clementine would be the open source equivalent of Windows Media Player.

@Clementine-Issue-Importer
Copy link
Author

From anthonyloomis on May 29, 2011 12:45:13

Requesting the ability to play cds and rip cds. It would catapult Clementine to the best player I've ever used, hands down.

@Clementine-Issue-Importer
Copy link
Author

From arnaud.bienner on June 09, 2011 16:14:42

CD support is now present ( r3372 ).
Currently, it works like in Amarok1.4 (Music -> Open CD).
Maybe we could also add CDs in Devices tab?
Also, even if it seems to work well for now, there is maybe (certainly?) some bugs to fix or some enhancements to do.
If you want to test, you're welcome ;)

Status: Started

@Clementine-Issue-Importer
Copy link
Author

From arnaud.bienner on June 14, 2011 10:43:07

Labels: Milestone-1.0

@Clementine-Issue-Importer
Copy link
Author

From schizosfera on July 04, 2011 04:56:49

all i get is a dialog: "Error while loading audio CD" when selecting "Music" -> "Open audio CD..."

console output:

13:48:17.354 INFO DeviceManager:393 Device added: "Gio//cdda/619577344"
13:48:29.926 INFO SongLoaderInserter:95 Loading audio CD...
13:48:29.945 ERROR SongLoader:115 Error while changing CDDA GstElement's state

the device manager displays an unmounted audio disc. the console output when attempting to mount:

13:49:07.922 INFO SongLoaderInserter:95 Loading audio CD...
13:49:07.946 ERROR SongLoader:115 Error while changing CDDA GstElement's state
13:51:21.325 ERROR OperationFinished:60 Mount/unmount error: mount: /dev/sda3 already mounted or /media/Foo busy
mount: according to mtab, /dev/sda3 is already mounted on /media/Foo

dev/sda3 is a local (already mounted) HDD.

@Clementine-Issue-Importer
Copy link
Author

From schizosfera on July 04, 2011 05:11:32

maybe it's worth mentioning that vlc plays the cds, while gnome mplayer managed to crash gdm when attempting to play a cd

@Clementine-Issue-Importer
Copy link
Author

From arnaud.bienner on August 04, 2011 17:16:33

This issue was closed by revision f7859f5 .

Status: Fixed

@Clementine-Issue-Importer
Copy link
Author

From arnaud.bienner on August 05, 2011 06:08:49

Now, CD devices are also displayed in devices tab (on the left). Previously, they were visible, but handle through Gio. (I'm not sure, but I think this may have lead to some of the errors mentioned in comment 25).
I'm not sure we will keep both ways (CD in devices tab and and "Music->Open Audio Cd") to access CDs: only in devices tab will be fine I believe.

It is working well on my side; but I wasn't able to test on every distribution/OS, so if you want to do so using the builds ( http://builds.clementine-player.org ), don't hesitate ;)

@Clementine-Issue-Importer
Copy link
Author

From schizosfera on August 05, 2011 07:00:24

does not comile here (clean build):

clementine-player/src/devices/cddalister.cpp:18:23: fatal error: cdio/cdio.h: No such file or directory
compilation terminated.
make[2]: *** [src/CMakeFiles/clementine_lib.dir/devices/cddalister.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [src/CMakeFiles/clementine_lib.dir/all] Error 2
make: *** [all] Error 2

@Clementine-Issue-Importer
Copy link
Author

From arnaud.bienner on August 05, 2011 07:15:05

You should install libcdio-dev package.

@Clementine-Issue-Importer
Copy link
Author

From schizosfera on August 10, 2011 07:17:23

"hatstand: QFileInfo info(device); if (info.isSymLink()) { continue; } might be good enough"

it actually fixed the problem (for me) and it also matches the strcmp("/dev/cdrom") case here (which in my case are just links to the sr* devices).

i also noticed that "^/dev/rdisk[0-9]$" matches only the first 10 such devices (should it maybe be "^/dev/rdisk[0-9]+$" ?). but i have no clue how cds with more than 10 tracks appear on macos.

@Clementine-Issue-Importer
Copy link
Author

From arnaud.bienner on August 10, 2011 07:20:54

Yes, indeed, I think this is the way to go: we should check for symbolic links and ignore them.

@Clementine-Issue-Importer
Copy link
Author

From john.maguire on August 10, 2011 08:07:19

The regex matches actual drives, tracks show up as /dev/rdisk1s1 for instance. I somewhat doubt anyone has more than 10 drives.

@Clementine-Issue-Importer
Copy link
Author

From arnaud.bienner on August 11, 2011 05:04:36

I've added the symbolic link check ( revision f963ae5 ).
So the last known problem that remains is the songs count which is not reset to zero when device is removed.

@Clementine-Issue-Importer
Copy link
Author

From john.maguire on August 11, 2011 05:49:51

I also need to write some Mac-specific code as libcdio doesn't detect drives until they contain a CD.

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on August 28, 2011 03:21:16

Could somebody tell me why I still cannot get a CD to play with Linux Mint 10 KDE? I am getting the latest updates for Clementine but it still doesn't work.

@Clementine-Issue-Importer
Copy link
Author

From arnaud.bienner on August 29, 2011 00:51:42

This feature will be available in next release (1.0), and isn't available in the current stable release.

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on August 29, 2011 14:36:55

Can anyone explain why Clementine plays CDs using Ubuntu and Zorin OS yet doesn't work with Linux Mint 10 KDE edition? I thought Clementine was a native KDE application.

@Clementine-Issue-Importer
Copy link
Author

From arnaud.bienner on August 29, 2011 23:34:26

Hey tomprend!
I already answer this question!! this feature will be available in the next stable release. For now, it is just available in the hourly builds.
About why we had to rewrite this part, I already explain this in comment 17.

@Clementine-Issue-Importer
Copy link
Author

From schizosfera on August 29, 2011 23:54:43

@tomprend: while clementine is inspred by amarok 1.4, it is actually built using the Qt library - for better portability i suppose. so it's less "native" to KDE as you probably assume - but it integrates very well. ;)

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on August 31, 2011 01:42:44

OK thanks for that

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on September 24, 2011 06:03:35

I am getting regular updates to Clementine from the David Sansome PPA. Although everything updates OK, I've noticed that 1) the rev level is still set to 0.7.1 and 2) I still cannot play CDs in Linux Mint.

@Clementine-Issue-Importer
Copy link
Author

From dominikmarczuk on November 01, 2011 19:03:57

OK, still no support for CDs... :(

Please do not state CDs are obsolete. This is like you were adopting the Apple attitude: CDs are obsolete, thus you'll get no CD reader in your Mac Mini. Let your CD collection rot. Duh! I happen to own ca. 500 CDs (original ones, if anyone asks). They cumulatively cost me a fortune and I use them on a regular basis. I would like to do so in Clementine, not Foobar2k, MediaMonkey or Banshee (depending on the computer I'm currently using).

@Clementine-Issue-Importer
Copy link
Author

From arnaud.bienner on November 02, 2011 06:46:15

@dominikm...@gmail.com: please take few seconds to read the previous comments before posting: the Audio CD support has been implemented, and will be available in next our release (1.0, it's indicated in comment 24).

@Clementine-Issue-Importer
Copy link
Author

From dominikmarczuk on November 02, 2011 17:35:43

@arnaud: comment #24 has no message whatsoever ;)

You mentioned that MAYBE it will be done in comment #17, and then confirmed in #52, though what I meant were the comments about CDs being obsolete more than the anticipation of a release with CD support. Though I believe I don't need to convince you specifically :).

Anyway, any (rough?) idea when we can expect to see a stable release with CD support? Is it a matter of weeks or months?

@Clementine-Issue-Importer
Copy link
Author

From jpeschken on January 02, 2012 09:26:13

I am getting a "Clementine Error" "Error while loading CD" on Ubuntu 10.04 Ubuntu and all my other applications load it without problem. Clementine looks and works great except for this one snag. Good job!

On the CD support issue. CD's are not quite dead yet. I still buy them because the quality of commercial MP3's is not up to what I would like. I rip them to FLAC and then transcode them to whatever format and maximum quality level each player can deal with. I am apparently fussier than most people, but then that's me.

Attachment: Screenshot-Clementine Error.png

@Clementine-Issue-Importer
Copy link
Author

From schizosfera on January 02, 2012 09:31:51

@62: it would probably be helpful to know what operating system and which clementine version you are using.

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on January 04, 2012 05:15:14

This also happens with Kubuntu 11.10 and version 0.7.3-540-g61aaefd. It did work for a while with earlier dev versions then suddenly broke.

@Clementine-Issue-Importer
Copy link
Author

From schizosfera on January 04, 2012 05:18:13

@64: v1.0 was released a while ago. you might want to try and upgrade.

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on January 04, 2012 08:34:47

I have the David Sansome PPA so I don't understand why I didn't get version 1. Anyway just downloaded it and still get the message Error while loading audio CD

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on January 05, 2012 12:16:20

I will have to stop rubbishing Amarok, I just tried again and it now plays CDs!! It's only taken them about three years to get back to the functionality of rev. 1.4

@Clementine-Issue-Importer
Copy link
Author

From arnaud.bienner on January 05, 2012 12:27:12

I use 1.0 on Ubuntu 10.04 and CD are working.
About the fact that it might has worked with previous releases, this is because on Linux, GIO can handle CD devices (even if it has not all the functionalities we need, like retrieving CD's tags).
But it wasn't working for Windows and Mac OS X.
Now (since 1.0) cdio and gstcdda handle CDs.
Try to install the 1.0 (from website if the PPA doesn't seem to be updated) and see if it still doesn't work.
If not, please open a new bug and attach some logs (start clementine from a terminal to get them)

@Clementine-Issue-Importer
Copy link
Author

From tomprendergast2 on January 05, 2012 13:18:40

I have installed it from the website, I will do as you say and file new bug report.

@Clementine-Issue-Importer
Copy link
Author

From felix.nagel on January 11, 2012 01:10:27

Ive tested v1.0.0 with Win7 and it seems not to work yet.

@Clementine-Issue-Importer
Copy link
Author

From hariskar on January 26, 2012 05:27:22

Ive tested v1.0.1 with Win7 and it seems not to work yet. I get "Error while loading audio CD".
At Devices I see my player but it says 0 songs.
Foobar plays it normally.
Any solution?

@Clementine-Issue-Importer
Copy link
Author

From hariskar on September 25, 2012 08:44:51

Still no CD support?? :-(

@Clementine-Issue-Importer
Copy link
Author

From burtekdotryw on February 11, 2013 11:18:27

Clementine does not see my CD drive (although it can see the virtual BDDVD drive of DAEMON Tools). Using Clementine 1.1.1 on 32-bit Win7-SP1.

@Clementine-Issue-Importer
Copy link
Author

From MrSeanRe on June 06, 2013 15:21:44

Seriously? Back to Winamp...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant