New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter library scanning behaviour. #45
Comments
From john.maguire on March 02, 2010 10:46:53 Labels: OpSys-All Component-MusicLibrary |
From davidsansome on March 03, 2010 03:51:19 Status: Accepted |
From kadaimx on March 20, 2010 17:29:30 This defect is still present in build 383. The main problem of this is not only the CPU consumption, but the heavy usage of HD A way to solve the problem is using the mtime in the database... but there can be Now, the command find is not present in each system, and even, it may not be all |
From davidsansome on March 21, 2010 09:29:59 After the first time you add a directory to the library, Clementine will only open a Clementine has to look at the mtime of each file - it can't skip a directory if the I've made the library scanner run at a lower IO priority on linux now ( r393 ), and the I'll leave this issue open for the start/pause scan menu items. Labels: -Milestone-0.2 Milestone-0.3 |
From kadaimx on March 25, 2010 00:56:11 Observations on the current way the library gets scanned: Changes on library get queued, but making almost a scan for each change. The scan process would, in any case, have a smart way to queue changes or detect This is a issue when managing large libraries. |
From davidsansome on April 01, 2010 10:02:07 I've had another think about this and I've come up with a much better library scanner. |
From kadaimx on April 01, 2010 15:07:08 Thank you for your efforts! Now, I'm going to say what I have found out in my test (some included adding new Library information (as for 1/april/2010): The first test was to create a empty folder in the library base folder Console output: Then, I followed to drop in that folder the link of a folder that was outside the Moved then them to the folder "Various Artist" inside "1900" (previously existing Restarted Clementine then, and console went spammed with mensages like this: (All those paths existed on my HD) Once restarted, Clementine sucessfully located the newly included folders, but showed QFileSystemWatcher: failed to add paths: /home/kadai/Music/COLLECTION/1900/Various I think that maybe the fault is mine. I'm going to delete the database and re-scan my |
From kadaimx on April 01, 2010 19:12:40 Wow, the system you happened to create works wonderfully. The only issues I see with it, is that it does not puts an eye on folders that were But if I organize a folder within an existing folder (ej: "/home/kadai/Music/COLLECTION/2010/Various Artists/GFCA-195 - from CD/15656 - It does requires some heavy test and being polished... despite that, it works as a charm. Kudos! |
From kadaimx on April 01, 2010 21:51:30 Just something I re-realized after some close watching. Hopefully, this is a small drawback. |
From kadaimx on April 03, 2010 11:07:34 And, other issue. I have been editing the composer tag of various files (from various locations, at |
From davidsansome on April 04, 2010 08:16:43 Thanks for testing :) I've fixed your bug from comment 7 (not monitoring new directories that are created I can't reproduce the second bug in comment 8 though - it works for me if I delete a I'm not going to be able to fix the bug in comment 10 - some other music players |
From kadaimx on April 04, 2010 13:32:20 Maybe I just did not wait enough time to make Clementine look for it (I added the And do not worry then for the issue on comment 10, gladly the scanner is pretty quick Of course, is important to leave this as reference for if some users uses other |
From kadaimx on April 04, 2010 16:05:51 This appear to not to happen always, but sometimes, when adding/moving files on the I was able to reproduce it moving to a album folder and the moving out from it a Aside, Clementine detected changes on all the files of the folder, but not sure if it [Thread 0xb567db70 (LWP 13918) exited] ( ... repeated for other 44 files ... ) "/home/kadai/Music/COLLECTION/2010/Various Artists/ロックマン10 宇宙からの脅威!! オリ |
From kadaimx on April 04, 2010 16:21:37 Well, it took actually around 10 minutes. Using the Debug Symbols. |
From davidsansome on April 05, 2010 08:23:12 It's fine that all the files in that folder "changed" - that was Clementine clearing Run: |
From kadaimx on April 05, 2010 09:36:52 Well, executed clementine on console using strace, and the output was too long that But, one of the things I noticed is that, when I moved the jpg file, the console got [pid 5379] stat64("/home/kadai/Music/COLLECTION/2001/Daft Punk/Discovery/12 - Short But the problem is that I removed the file from: Why then was scanning those folders? But then, no idea why Clementine was stating those folders (specially the last two, I hope this helps. |
From davidsansome on April 15, 2010 09:50:34 I haven't been able to reproduce this since you posted your comment so I'm going to Status: Fixed |
From kadaimx on April 24, 2010 16:38:20 I apparently discovered what was wrong with my setup. In my previous installs, I had activated the -user folder- encryption. I'm not sure What I'm thinking is that the files where touched -somehow- by the encrypt system, This is the reason of the problem, so if someone else comes with this, be sure to |
From davidsansome on April 26, 2010 04:19:11 Ah that's useful to know, and interesting that it would cause that behaviour. Glad |
From silverwraithii on March 01, 2010 19:40:04
I haven't looked at the code, but it appears that a full library scan is
done every startup.
This behaviour doesn't seem scalable; with 40000 audio files in my library
directories, it results in Clementine saturating a CPU core for
approximately 5 minutes.
I think the ideal approach is to store mtime in the database, only
descending into a directory if its mtime is newer than what's stored.
Tangentially, it'd be nice to have the ability to start or pause a scan at
will via a menu option.
Original issue: http://code.google.com/p/clementine-player/issues/detail?id=45
The text was updated successfully, but these errors were encountered: