Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always display embedded cover art in the 'edit song' dialog and the 'now playing' widget #1232

Closed
Clementine-Issue-Importer opened this issue Dec 7, 2013 · 0 comments

Comments

@Clementine-Issue-Importer

From regis.patroix on January 04, 2011 00:52:21

Display Cover art from embedded image for the current song.

Attachment: cover.jpg

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=1232

@Clementine-Issue-Importer
Copy link
Author

From keirangtp on January 04, 2011 05:40:49

Also, i was able to find a situation when both, the 'edit song' dialog and the 'now playing' widget, were unable to show the embedded cover art.

Summary: always display embedded cover art in the 'edit song' dialog and the 'now playing' widget
Status: Accepted
Labels: Component-UI

@Clementine-Issue-Importer
Copy link
Author

From markwatkinson on January 04, 2011 10:50:03

There are two separate issues here. The first, in the OP, is that Clementine erroneously drops the 'embedded' indicator when it updates songs in the database (and maybe when they're first inserted, not sure). It looks like the tag dialogue reads the tag from the music file rather than the database, hence it detects embedded art there.

The second, when neither the tag dialogue nor the other places (now playing widget, library view in trunk) seem to know about the embedded art presumably occurs because it didn't manage to detect the embedded art when it loaded the file in the first place.

I have attached a patch for the first issue, but the offending files need to be touched or otherwise updated before Clementine will update their entry in the database.

Attachment: clementine_embedded_art.diff

@Clementine-Issue-Importer
Copy link
Author

From markwatkinson on January 04, 2011 16:19:01

...see also separate patch to enable Clementine to recognise embedded cover art in ogg files. [attached]

Attachment: clementine_embedded_ogg_art.diff

@Clementine-Issue-Importer
Copy link
Author

From keirangtp on January 05, 2011 05:05:06

Thanks for the patches! Could you review those David?

Status: Started
Owner: davidsansome

@Clementine-Issue-Importer
Copy link
Author

From keirangtp on January 08, 2011 08:14:11

Issue 1255 has been merged into this issue.

@Clementine-Issue-Importer
Copy link
Author

From davidsansome on January 23, 2011 07:51:04

This issue was closed by revision r2685 .

Status: Fixed

@Clementine-Issue-Importer
Copy link
Author

From davidsansome on January 23, 2011 07:51:26

Thanks Mark, sorry for taking so long to look at your patches. I've committed them both now!

@Clementine-Issue-Importer
Copy link
Author

From markwatkinson on January 23, 2011 08:50:43

Don't worry about it, glad they were useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant