My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 99190: kExtraInfo in component_updater_configurator.cc not defined for ARM on OS_CHROMEOS
2 people starred this issue and may be notified of changes. Back to list
Status:  Verified
Owner:  cpu@chromium.org
Closed:  Oct 2011
Cc:  cpu@chromium.org, stevenjb@chromium.org

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
 
Project Member Reported by stevenjb@chromium.org, Oct 5, 2011
http://codereview.chromium.org/8122015 broke the ChromiumOS(arm) builder: http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28arm%29/builds/233

From http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28arm%29/builds/233/steps/cbuildbot_chrome/logs/stdio:

chromeos-chrome-16.0.901.0_alpha-r1: chrome/browser/component_updater/component_updater_configurator.cc:59:6: error: #error "unknown linux architecture"
chromeos-chrome-16.0.901.0_alpha-r1:   armv7a-cros-linux-gnueabi-g++ -B/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.21-gold '-DNO_TCMALLOC' '-DNO_HEAPCHECKER' '-DDISABLE_NACL' '-DCHROMIUM_BUILD' '-DTOOLKIT_VIEWS=1' '-DTOOLKIT_USES_GTK=1' '-DOS_CHROMEOS=1' '-DFILE_MANAGER_EXTENSION=1' '-DWEBUI_TASK_MANAGER=1' '-DENABLE_REMOTING=1' '-DENABLE_P2P_APIS=1' '-DENABLE_FLAPPER_HACKS=1' '-DENABLE_CONFIGURATION_POLICY' '-DENABLE_GPU=1' '-DENABLE_EGLIMAGE=1' '-DUSE_SKIA=1' '-DENABLE_REGISTER_PROTOCOL_HANDLER=1' '-DNACL_WINDOWS=0' '-DNACL_LINUX=1' '-DNACL_OSX=0' '-DENABLE_SAFE_BROWSING' '-DENABLE_SMOOTH_SCROLLING' '-DGL_GLEXT_PROTOTYPES' '-DSK_BUILD_NO_IMAGE_ENCODE' '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' '-DGR_AGGRESSIVE_SHADER_OPTS=1' '-DUSE_SYSTEM_LIBBZ2' '-DCLD_WINDOWS' '-DCOMPILER_GCC' '-DHUNSPELL_STATIC' '-DHUNSPELL_CHROME_CLIENT' '-DUSE_HUNSPELL' '-DU_USING_ICU_NAMESPACE=0' '-DU_STATIC_IMPLEMENTATION' '-DFEATURE_ENABLE_SSL' '-DFEATURE_ENABLE_VOICEMAIL' '-DEXPAT_RELATIVE_PATH' '-DWEBRTC_RELATIVE_PATH' '-DLINUX' '-DPOSIX' '-DLIBXML_STATIC' '-DHAVE_IBUS=1' '-DGOOGLE_PROTOBUF_NO_RTTI' '-D__STDC_FORMAT_MACROS' '-DNDEBUG' '-DNVALGRIND' '-DDYNAMIC_ANNOTATIONS_ENABLED=0' -Ithird_party/icu/public/common -Ithird_party/icu/public/i18n -I. -Ic/Release/obj.target/geni -Ic/Release/obj.target/geni/chrome -Ithird_party -Igpu -Ic/Release/obj/gen/policy -Ic/Release/obj/gen/protoc_out -Ic/Release/obj/gen/chrome -Ithird_party/sqlite -Iskia/config -Ithird_party/skia/include/config -Ithird_party/skia/include/core -Ithird_party/skia/include/effects -Ithird_party/skia/include/pdf -Ithird_party/skia/include/gpu -Ithird_party/skia/include/ports -Ithird_party/skia/gpu/include -Iskia/ext -Ithird_party/cld -Ithird_party/leveldatabase/src/include -Ithird_party/leveldatabase/src -Ithird_party/libjingle/overrides -Ithird_party/libjingle/source -Ic/Release/obj/gen/protoc_out/third_party/libphonenumber -Ithird_party/libxml/linux/include -Ithird_party/libxml/src/include -Ithird_party/npapi -Ithird_party/npapi/bindings -Ic/Release/obj/gen/ui/app_locale_settings -Ic/Release/obj/gen/ui/ui_strings -Ic/Release/obj/gen/ui/ui_resources -Ic/Release/obj/gen/ui/ui_resources_large -Ic/Release/obj/gen/ui/ui_resources_standard -Ic/Release/obj/gen/webkit -Ic/Release/obj/gen -Ic/Release/obj/gen/protoc_out/third_party/mozc -Inet/third_party/nss/ssl -Ithird_party/protobuf -Ithird_party/protobuf/src -Werror -pthread -fno-exceptions -Wall -Wno-unused-parameter -Wno-missing-field-initializers -D_FILE_OFFSET_BITS=64 -fvisibility=hidden -pipe -fPIC -fno-strict-aliasing -I/build/arm-generic/usr/include/glib-2.0 -I/build/arm-generic/usr/lib/glib-2.0/include -pthread -I/build/arm-generic/usr/include/dbus-1.0 -I/build/arm-generic/usr/lib/dbus-1.0/include -I/build/arm-generic/usr/include/glib-2.0 -I/build/arm-generic/usr/lib/glib-2.0/include -pthread -I/build/arm-generic/usr/include/ibus-1.0 -I/build/arm-generic/usr/include/glib-2.0 -I/build/arm-generic/usr/lib/glib-2.0/include -I/build/arm-generic/usr/include/dbus-1.0 -I/build/arm-generic/usr/lib/dbus-1.0/include -pthread -I/build/arm-generic/usr/include/gtk-2.0 -I/build/arm-generic/usr/lib/gtk-2.0/include -I/build/arm-generic/usr/include/atk-1.0 -I/build/arm-generic/usr/include/cairo -I/build/arm-generic/usr/include/pango-1.0 -I/build/arm-generic/usr/include/glib-2.0 -I/build/arm-generic/usr/lib/glib-2.0/include -I/build/arm-generic/usr/include/pixman-1 -I/build/arm-generic/usr/include/freetype2 -I/build/arm-generic/usr/include/libpng12 -pthread -I/build/arm-generic/usr/include/gtk-unix-print-2.0 -I/build/arm-generic/usr/include/gtk-2.0 -I/build/arm-generic/usr/include/atk-1.0 -I/build/arm-generic/usr/include/cairo -I/build/arm-generic/usr/include/pango-1.0 -I/build/arm-generic/usr/lib/gtk-2.0/include -I/build/arm-generic/usr/include/glib-2.0 -I/build/arm-generic/usr/lib/glib-2.0/include -I/build/arm-generic/usr/include/pixman-1 -I/build/arm-generic/usr/include/freetype2 -I/build/arm-generic/usr/include/libpng12 -I/build/arm-generic/usr/include/nss -I/build/arm-generic/usr/include/nspr -march=armv7-a -mtune=cortex-a8 -mfloat-abi=softfp -mfpu=neon --sysroot=/build/arm-generic/ -O2 -fno-ident -fdata-sections -ffunction-sections -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-abi -MMD -MF c/Release/.deps/c/Release/obj.target/browser/chrome/browser/component_updater/component_unpacker.o.d.raw   -pipe -I/build/arm-generic/usr/include/ -I/build/arm-generic/include/ -ggdb -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -Wno-error=unused-but-set-variable -c -o c/Release/obj.target/browser/chrome/browser/component_updater/component_unpacker.o chrome/browser/component_updater/component_unpacker.cc
chromeos-chrome-16.0.901.0_alpha-r1: chrome/browser/component_updater/component_updater_configurator.cc:71:1: error: expected primary-expression before ‘}’ token
chromeos-chrome-16.0.901.0_alpha-r1: chrome/browser/component_updater/component_updater_configurator.cc:71:1: error: expected ‘,’ or ‘;’ before ‘}’ token


Oct 5, 2011
#1 bugdroid1@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104126

------------------------------------------------------------------------
r104126 | stevenjb@google.com | Wed Oct 05 10:39:07 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/component_updater_configurator.cc?r1=104126&r2=104125&pathrev=104126

Provide default extra info for non x86 architectures on ChromeOS

BUG=99190
TEST=ARM bots build

Review URL: http://codereview.chromium.org/8139033
------------------------------------------------------------------------
Oct 5, 2011
#2 stevenjb@chromium.org
(No comment was entered for this change.)
Owner: cpu@chromium.org
Cc: stevenjb@chromium.org
Oct 5, 2011
#3 cpu@chromium.org
(No comment was entered for this change.)
Status: Fixed
Oct 19, 2011
#4 bugdroid1@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106343

------------------------------------------------------------------------
r106343 | stevenjb@chromium.org | Wed Oct 19 12:20:28 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/component_updater_configurator.cc?r1=106343&r2=106342&pathrev=106343

Provide extra info form ARM

BUG=99190
TEST=ARM bots build


Review URL: http://codereview.chromium.org/8139038
------------------------------------------------------------------------
Jun 1, 2012
#5 kr...@chromium.org
Been fixed forever and milestone has passed.
Jun 1, 2012
#6 kr...@chromium.org
(No comment was entered for this change.)
Status: Verified
Oct 13, 2012
#7 bugdroid1@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#8 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Mstone-16 -TreeCloser Hotlist-TreeCloser M-16
Mar 13, 2013
#9 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment

Powered by Google Project Hosting