My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 98882: Pull updated open-vcdiff to pass licensecheck
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  j...@chromium.org
Closed:  Jul 2012

Blocked on:
issue open-vcdiff:31

Blocking:
issue 28291

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Project Member Reported by phajdan.jr@chromium.org, Oct 3, 2011
licensecheck problems have been fixed upstream in https://code.google.com/p/open-vcdiff/issues/detail?id=31, but we need to pull that version to Chromium repo (sdch/open-vcdiff) and remove suppression from tools/checklicenses/checklicenses.py

The target version number of open-vcdiff is 0.8.2 or greater. Please remember to remove the suppression from checklicenses.py.
Oct 3, 2011
#1 phajdan.jr@chromium.org
(No comment was entered for this change.)
Blocking: 28291
Oct 3, 2011
#2 j...@chromium.org
(No comment was entered for this change.)
Status: Started
Oct 4, 2011
#3 phajdan.jr@chromium.org
A clarifying update:

1. Make sure all files in question have license headers that identify the license. It doesn't have to contain full text of the license, but it should identify the license type precisely enough, e.g. "APSL" or "BSD (3-clause)".

   - if the project in question is developed by Google, there is no excuse; go and fix it
   - if it's a third party project, we should ask them to add license headers (a bug should be filed); then you can put the third party bug link in the Chromium bug and change the Chromium bug status to ExternalDependency

2. We don't add the license headers ourselves to code we didn't write. Added because people asked about that.

3. If the files have license headers but they're still not recognized, third_party/devscripts/licensecheck.pl should be patched. Please remember to also update chromium-1.patch (you can get original licensecheck.pl by reverse-applying that patch). You _don't_ need to upstream your changes, I'll take care of that. In fact, if you don't feel like messing with perl or reverse-applying things, just send me your regular expressions (make sure they're good).

4. Finnally, the suppression should be removed from tools/checklicenses/checklicenses.py . Please respect OWNERS of that file.

That should be it, thank you for your feedback and work on the bugs (11 bugs have already been fixed).
Nov 6, 2011
#4 j...@chromium.org
(No comment was entered for this change.)
Status: Fixed
Nov 7, 2011
#5 phajdan.jr@chromium.org
Please also remove the suppression, see http://src.chromium.org/viewvc/chrome/trunk/src/tools/checklicenses/checklicenses.py?view=log#revHEAD and message above.
Status: Started
Jul 26, 2012
#6 j...@chromium.org
No visible mention of vcdiff in the checklicenses.py file
Status: Fixed
Blockedon: -open-vcdiff:31 open-vcdiff:31
Oct 13, 2012
#7 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Blocking: -chromium:28291 chromium:28291
Mar 10, 2013
#8 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-Internals Cr-Internals
Sign in to add a comment

Powered by Google Project Hosting