My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 98116: third_party/ashmem fails licensecheck
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  michaelbai@chromium.org
Closed:  Oct 2011

Blocking:
issue 28291

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Project Member Reported by phajdan.jr@chromium.org, Sep 26, 2011
$ tools/checklicenses/checklicenses.py --ignore-suppressions third_party/ashmem/
'third_party/ashmem/ashmem.h' has non-whitelisted license 'UNKNOWN'

Please make sure those files have license headers and make third_party/devscripts/licensecheck.pl recognize them. Patches to that script should be submitted upstream.
Sep 26, 2011
#1 phajdan.jr@chromium.org
(No comment was entered for this change.)
Blocking: 28291
Sep 29, 2011
#2 michaelbai@chromium.org
phajdan,

This file is dual licensed, like below, Do you have any suggestion about how to fix it?

/*
 * Copyright 2008 The Android Open Source Project
 **
 ** This file is dual licensed.  It may be redistributed and/or modified
 ** under the terms of the Apache 2.0 License OR version 2 of the GNU
 ** General Public License.
 */


Sep 29, 2011
#3 phajdan.jr@chromium.org
Ah, that's great news. We should modify third_party/devscripts/licensecheck.pl to recognize this as dual Apache 2.0, GPL 2 and send our patch to Debian. I can help you with that, feel free to contact me off-tracker.

After doing that the suppression should be removed from tools/checklicenses/checklicenses.py (actually it can be done in the same commit).
Sep 29, 2011
#4 michaelbai@chromium.org
I don't understand how things work, Would you mind help to do this?
Sep 30, 2011
#5 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=103594

------------------------------------------------------------------------
r103594 | michaelbai@chromium.org | Fri Sep 30 17:05:45 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/devscripts/chromium-1.patch?r1=103594&r2=103593&pathrev=103594
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/checklicenses/checklicenses.py?r1=103594&r2=103593&pathrev=103594
 M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/devscripts/licensecheck.pl?r1=103594&r2=103593&pathrev=103594

Make the license tools recoginze the dual license


BUG=98116
TEST=


Review URL: http://codereview.chromium.org/8094004
------------------------------------------------------------------------
Oct 3, 2011
#6 phajdan.jr@chromium.org
(No comment was entered for this change.)
Status: Fixed
Jan 25, 2012
#7 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=119209

------------------------------------------------------------------------
r119209 | phajdan.jr@chromium.org | Wed Jan 25 23:41:31 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/checklicenses/checklicenses.py?r1=119209&r2=119208&pathrev=119209

Remove unused checklicenses suppressions.

BUG=98086, 105232, 98116, 98316
Review URL: http://codereview.chromium.org/9235032
------------------------------------------------------------------------
Oct 12, 2012
#8 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Blocking: -chromium:28291 chromium:28291
Mar 10, 2013
#9 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-Internals Cr-Internals
Sign in to add a comment

Powered by Google Project Hosting