My favorites ▼ | Sign in
Logo
Project Home
  
Downloads
  
Wiki
  
Issues
    
New issue | Search
for
| Advanced search | Search tips
Issue 9663: cannot go back to previous page after visitng hp.com
3 people starred this issue and may be notified of changes. Back to list
 
Reported by aocampo@chromium.org, Apr 02, 2009 
What steps will reproduce the problem?
1. Open a tab to say wwww.google.com
2. In the same tab, navigate to www.apple.com
3. In the same tab, navigate to www.hp.com (you will get redirected to http://www.hp.com/#Product)
4. Click on the back button

What is the expected output? 
I am redirected back to www.apple.com

What do you see instead?
I am redirected to http://www.hp.com/country/us/en//country/us/en/welcome.html 
Another click on the back button will take me back to http://www.hp.com/#Product

*Any succeeding clicks to the back button will just take me back and forth 
to these 2 links.

Please use labels and text to provide additional information.
FF3 / IE 7: ok
Safari 4 (nightly 41855): not ok (same as Chrome)
Chrome 1.0.154.53: not ok
Chrome 2.0.169.1: not ok
Chrome 2.0.173.0 (13014): not ok
Comment 1 by jon@chromium.org, Apr 02, 2009 
(No comment was entered for this change.)
Status: Available
Owner: ---
Cc: aoca...@chromium.org
Labels: -Area-Misc Area-BrowserBackend Mstone-2.0 Size-Medium
Comment 2 by jon@chromium.org, Apr 03, 2009 
Moving from milestone 2 to milestone 2.1.
Labels: JonMoved Mstone-2.1
Comment 3 by y...@google.com, Apr 14, 2009 
(No comment was entered for this change.)
Owner: y...@google.com
Comment 4 by bugdroid1@chromium.org, May 13, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=15950 

------------------------------------------------------------------------
r15950 | maruel@chromium.org | 2009-05-13 06:22:45 -0700 (Wed, 13 May 2009) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.cc?r1=15950&r2=15949
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.h?r1=15950&r2=15949
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/HistoryHelper.js?r1=15950&r2=15949
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test1.html?r1=15950&r2=15949
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test2.html?r1=15950&r2=15949
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_1.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_2.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_3.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_4.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/history_uitest.cc?r1=15950&r2=15949

This is the successor to http://codereview.chromium.org/67150

Make forward/backward navigation work even when redirection is involved.

Currently, Chrome tries to go back to the page immediately before
the current one. This doesn't work if the current page was visited
by redirection; redirection just occurs again.

With this change, Chrome first tries to find the redirection source
of the current page and then to go back to the page before the source.

BUG=9663,10531

Tested: unit_tests, ui_tests, manually.

Patch contributed by Yuzo Fujishima <yuzo@google.com>

Review: http://codereview.chromium.org/100245
------------------------------------------------------------------------
Comment 5 by y...@google.com, May 14, 2009 
(No comment was entered for this change.)
Status: Fixed
Comment 6 by mberkow...@chromium.org, May 20, 2009 
Verified in Chrome 2.0.181.1 (Official Build 16409) and Chromium 2.0.182.0 (Developer
Build 16485).
Status: Verified
Comment 7 by eroman@chromium.org, Jun 30, 2009 
 Issue 15720  has been merged into this issue.
Comment 8 by mal.chromium, Jun 30, 2009 
(No comment was entered for this change.)
Owner: y...@chromium.org
Labels: Merge-Stable
Comment 9 by bugdroid1@chromium.org, Jul 03, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=19923 

------------------------------------------------------------------------
r19923 | mal@chromium.org | 2009-07-03 17:35:22 -0700 (Fri, 03 Jul 2009) | 14 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/tab_contents/navigation_controller.cc?r1=19923&r2=19922
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/tab_contents/navigation_controller.h?r1=19923&r2=19922
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/HistoryHelper.js?r1=19923&r2=19922
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/history_length_test1.html?r1=19923&r2=19922
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/history_length_test2.html?r1=19923&r2=19922
   A http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/history_length_test_page_1.html
   A http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/history_length_test_page_2.html
   A http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/history_length_test_page_3.html
   A http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/history_length_test_page_4.html
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/ui/history_uitest.cc?r1=19923&r2=19922

Merge r15950.

Make forward/backward navigation work even when redirection is involved.

Currently, Chrome tries to go back to the page immediately before
the current one. This doesn't work if the current page was visited
by redirection; redirection just occurs again.

With this change, Chrome first tries to find the redirection source
of the current page and then to go back to the page before the source.

BUG=9663,10531

Tested: unit_tests, ui_tests, manually.
------------------------------------------------------------------------
Comment 10 by venkataramana@chromium.org, Jul 14, 2009 
Works fine on stable: 2.0.172.38
Comment 11 by bugdroid1@chromium.org, Jul 23, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=21501 

------------------------------------------------------------------------
r21501 | laforge@chromium.org | 2009-07-23 19:00:09 -0700 (Thu, 23 Jul 2009) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/tab_contents/navigation_controller.cc?r1=21501&r2=21500
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/tab_contents/navigation_controller.h?r1=21501&r2=21500
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/HistoryHelper.js?r1=21501&r2=21500
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/history_length_test1.html?r1=21501&r2=21500
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/history_length_test2.html?r1=21501&r2=21500
   D /branches/172/src/chrome/test/data/History/history_length_test_page_1.html
   D /branches/172/src/chrome/test/data/History/history_length_test_page_2.html
   D /branches/172/src/chrome/test/data/History/history_length_test_page_3.html
   D /branches/172/src/chrome/test/data/History/history_length_test_page_4.html
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/ui/history_uitest.cc?r1=21501&r2=21500

Revert 19923 - Merge r15950.

Make forward/backward navigation work even when redirection is involved.

Currently, Chrome tries to go back to the page immediately before
the current one. This doesn't work if the current page was visited
by redirection; redirection just occurs again.

With this change, Chrome first tries to find the redirection source
of the current page and then to go back to the page before the source.

BUG=9663,10531

Tested: unit_tests, ui_tests, manually.

TBR=mal@chromium.org

Review URL: http://codereview.chromium.org/159329
------------------------------------------------------------------------
Comment 12 by progame, Jul 24, 2009 
this issue is related to the merge in  Issue 11896  and maybe in  Issue 11355  too (just a 
reminder as i am not sure how the stable merging process works)
Comment 13 by mberkow...@chromium.org, Jul 27, 2009 
This was working OK in 172.37, but not OK in 172.39.
Cc: suna...@chromium.org
Comment 14 by y...@chromium.org, Jul 27, 2009 
Mitchell,
You mean 2.0.172.{37,39}, don't you?
Then this is the expected "regression" to fix more serious issue.

Anthony,
Please correct me if misunderstood the situation.

Yuzo
Owner: lafo...@chromium.org
Cc: lafo...@chromium.org
Comment 15 by sunandt@chromium.org, Jul 28, 2009 
Yes that's right. This is expected regression to fix other regressions.
Comment 16 by mal.chromium, Dec 18, 2009 
(No comment was entered for this change.)
Labels: -Area-BrowserBackend Area-Internals
► Sign in to add a comment

Powered by Google Project Hosting