My favorites ▼ | Sign in
Project Home Downloads Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 95810: IE Security protected mode warning when opening link in Gmail
3 people starred this issue and may be notified of changes. Back to list
 
Reported by project member grt@chromium.org, Sep 8, 2011 
ChromeFrame version: 15.0.865.0 (dev channel, system level, single install)
Windows 7 x64, IE 8

Related URL(s): https://mail.google.com/

Steps to reproduce the issue:
1. Run IE
2. Open a Gmail message containing a hyperlink
3. Wait for Google Update to run an in-place update (opv=15.0.865.0, pv=15.0.874.0); see attached installer log.
4. Click on the hyperlink in the mail message

What do you expect to happen?

A new tab to open showing the linked-to page.

What do you see instead?

See attached PNG.  A new tab opened navigating to https://mail.google.com/?attach_external_tab&157037120&3&0&0&0&0&iexplore
and an "Internet Explorer Security" window opened saying "This program will open outside of Protected mode. Internet Explorer's Protected mode helps protect your computer. If you do not trust this website, do not open this program."

This looks similar to  issue 51747 .
IESecurity.PNG
214 KB   View   Download
chrome_frame_installer.log
8.3 KB   View   Download
Comment 1 by grt@chromium.org, Sep 8, 2011 
In brief, Chrome Frame breaks when an in-use update takes place.  This is unacceptable for a stable release, so a fix should block M15 going stable.  This is a regression introduced in http://crrev.com/92706.
Status: Assigned
Owner: grt@chromium.org
Labels: -Type-Bug -Pri-2 Type-Regression Pri-0 Mstone-15 ReleaseBlock-Stable
Comment 2 by bugdro...@chromium.org, Sep 17, 2011 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=101684

------------------------------------------------------------------------
r101684 | grt@chromium.org | Sat Sep 17 19:47:17 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/delete_reg_key_work_item_unittest.cc?r1=101684&r2=101683&pathrev=101684
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/delete_reg_key_work_item.h?r1=101684&r2=101683&pathrev=101684
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/delete_reg_key_work_item.cc?r1=101684&r2=101683&pathrev=101684
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/copy_reg_key_work_item_unittest.cc?r1=101684&r2=101683&pathrev=101684
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/work_item_list.cc?r1=101684&r2=101683&pathrev=101684
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/copy_reg_key_work_item.h?r1=101684&r2=101683&pathrev=101684
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/registry_key_backup.cc?r1=101684&r2=101683&pathrev=101684 (from /trunk/src/chrome/installer/util/delete_reg_key_work_item.cc revision 101678)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/work_item.cc?r1=101684&r2=101683&pathrev=101684
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/registry_test_data.cc?r1=101684&r2=101683&pathrev=101684
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/work_item.h?r1=101684&r2=101683&pathrev=101684
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/registry_test_data.h?r1=101684&r2=101683&pathrev=101684
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_installer.gypi?r1=101684&r2=101683&pathrev=101684
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/registry_key_backup_unittest.cc?r1=101684&r2=101683&pathrev=101684
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/registry_key_backup.h?r1=101684&r2=101683&pathrev=101684
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_installer_util.gypi?r1=101684&r2=101683&pathrev=101684
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/work_item_list.h?r1=101684&r2=101683&pathrev=101684
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/copy_reg_key_work_item.cc?r1=101684&r2=101683&pathrev=101684

Added CopyRegKeyWorkItem in support of IE low rights policy fixes.

A subsequent CL will contain the rest of the fixes for the bug.

BUG=95810
TEST=installer_util_unittests.exe

Review URL: http://codereview.chromium.org/7890069
------------------------------------------------------------------------
Comment 3 by bugdro...@chromium.org, Sep 23, 2011 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=102569

------------------------------------------------------------------------
r102569 | grt@chromium.org | Fri Sep 23 13:48:58 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/uninstall.cc?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_frame_elevation.rgs?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/copy_reg_key_work_item_unittest.cc?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/work_item_list.cc?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/copy_reg_key_work_item.h?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_tab.cc?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/install.cc?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/work_item.cc?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/install_worker.cc?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/install_worker_unittest.cc?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/work_item.h?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/install_worker.h?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/setup_main.cc?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/work_item_list.h?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/copy_reg_key_work_item.cc?r1=102569&r2=102568&pathrev=102569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_frame_activex.rgs?r1=102569&r2=102568&pathrev=102569

Fix in-use updates for Chrome Frame.

On in-use updates, make a copy of the old chrome launcher's IE low rights elevation policy prior to registering the new npchrome_frame.dll so that running instances of IE can still launch Chrome.

In so doing, I also removed elevation policy addition/removal code from the installer so that npchrome_frame.dll's {un,}registration code is the one and only place where this is done.

BUG=95810
TEST=Install a previous version of GCF, run IE and visit some page that activates GCF, update to a version of GCF containing this fix, then try to visit another page that will activate GCF.  If all goes well, you won't see an IE security prompt.

Review URL: http://codereview.chromium.org/7976045
------------------------------------------------------------------------
Comment 4 by grt@chromium.org, Sep 24, 2011 
Fixed in 16.0.891.0.
Status: Fixed
Comment 5 by grt@chromium.org, Sep 26, 2011 
(No comment was entered for this change.)
Labels: Merge-Requested
Comment 6 by kar...@google.com, Sep 26, 2011 
this made it to today's dev so please just make sure you check it after it goes out and assuming we're safe, we'll merge it before wed night.
Comment 7 by grt@chromium.org, Sep 27, 2011 
I tested an in-use update from 889.0 to 891.0 on the dev channel today, and it worked as desired.  I believe http://crrev.com/101684 and http://crrev.com/102569 are safe to merge.
Comment 8 by kar...@google.com, Sep 28, 2011 
(No comment was entered for this change.)
Labels: -Merge-Requested Merge-Approved
Comment 9 by bugdro...@chromium.org, Sep 28, 2011 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=103164

------------------------------------------------------------------------
r103164 | grt@chromium.org | Wed Sep 28 13:09:17 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/delete_reg_key_work_item_unittest.cc?r1=103164&r2=103163&pathrev=103164
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/delete_reg_key_work_item.h?r1=103164&r2=103163&pathrev=103164
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/delete_reg_key_work_item.cc?r1=103164&r2=103163&pathrev=103164
 A http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/copy_reg_key_work_item_unittest.cc?r1=103164&r2=103163&pathrev=103164 (from /trunk/src/chrome/installer/util/copy_reg_key_work_item_unittest.cc revision 101684)
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/work_item_list.cc?r1=103164&r2=103163&pathrev=103164
 A http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/copy_reg_key_work_item.h?r1=103164&r2=103163&pathrev=103164 (from /trunk/src/chrome/installer/util/copy_reg_key_work_item.h revision 101684)
 A http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/registry_key_backup.cc?r1=103164&r2=103163&pathrev=103164 (from /trunk/src/chrome/installer/util/registry_key_backup.cc revision 101684)
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/work_item.cc?r1=103164&r2=103163&pathrev=103164
 A http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/registry_test_data.cc?r1=103164&r2=103163&pathrev=103164 (from /trunk/src/chrome/installer/util/registry_test_data.cc revision 101684)
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/work_item.h?r1=103164&r2=103163&pathrev=103164
 A http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/registry_test_data.h?r1=103164&r2=103163&pathrev=103164 (from /trunk/src/chrome/installer/util/registry_test_data.h revision 101684)
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/chrome_installer.gypi?r1=103164&r2=103163&pathrev=103164
 A http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/registry_key_backup_unittest.cc?r1=103164&r2=103163&pathrev=103164 (from /trunk/src/chrome/installer/util/registry_key_backup_unittest.cc revision 101684)
 A http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/registry_key_backup.h?r1=103164&r2=103163&pathrev=103164 (from /trunk/src/chrome/installer/util/registry_key_backup.h revision 101684)
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/chrome_installer_util.gypi?r1=103164&r2=103163&pathrev=103164
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/work_item_list.h?r1=103164&r2=103163&pathrev=103164
 A http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/copy_reg_key_work_item.cc?r1=103164&r2=103163&pathrev=103164 (from /trunk/src/chrome/installer/util/copy_reg_key_work_item.cc revision 101684)

Merge 101684 - Added CopyRegKeyWorkItem in support of IE low rights policy fixes.

A subsequent CL will contain the rest of the fixes for the bug.

BUG=95810
TEST=installer_util_unittests.exe

Review URL: http://codereview.chromium.org/7890069

TBR=grt@chromium.org
------------------------------------------------------------------------
Labels: -merge-approved merge-merged-874
Comment 10 by bugdro...@chromium.org, Sep 28, 2011 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=103165

------------------------------------------------------------------------
r103165 | grt@chromium.org | Wed Sep 28 13:12:06 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/setup/uninstall.cc?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome_frame/chrome_frame_elevation.rgs?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/copy_reg_key_work_item_unittest.cc?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/setup/install.cc?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/work_item_list.cc?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/copy_reg_key_work_item.h?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome_frame/chrome_tab.cc?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/work_item.cc?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/setup/install_worker.cc?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/setup/install_worker_unittest.cc?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/work_item.h?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/setup/install_worker.h?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/setup/setup_main.cc?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/work_item_list.h?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/copy_reg_key_work_item.cc?r1=103165&r2=103164&pathrev=103165
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome_frame/chrome_frame_activex.rgs?r1=103165&r2=103164&pathrev=103165

Merge 102569 - Fix in-use updates for Chrome Frame.

On in-use updates, make a copy of the old chrome launcher's IE low rights elevation policy prior to registering the new npchrome_frame.dll so that running instances of IE can still launch Chrome.

In so doing, I also removed elevation policy addition/removal code from the installer so that npchrome_frame.dll's {un,}registration code is the one and only place where this is done.

BUG=95810
TEST=Install a previous version of GCF, run IE and visit some page that activates GCF, update to a version of GCF containing this fix, then try to visit another page that will activate GCF.  If all goes well, you won't see an IE security prompt.

Review URL: http://codereview.chromium.org/7976045

TBR=grt@chromium.org
------------------------------------------------------------------------
Comment 11 by pavanv@chromium.org, Sep 29, 2011 
Installed 874.51 GCF and navigated to crbug.com, got IE security prompt.

Updated to 874.54 GCF and navigated to crbug.com, no IE security prompt. Closing the bug as verified.
Status: Verified
Comment 12 by robertsh...@chromium.org, Oct 5, 2011 
 Issue 99204  has been merged into this issue.
Cc: grt@chromium.org
Comment 13 by grt@chromium.org, Oct 6, 2011 
Hi Kerz, this is a top crasher in M14 (see  issue 99204  for crash report), so we'd like to merge.  Thanks.
Labels: Mstone-14 Merge-Requested
Comment 14 by bugdro...@chromium.org, Oct 6, 2011 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104338

------------------------------------------------------------------------
r104338 | grt@chromium.org | Thu Oct 06 11:56:05 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/chrome_installer_util.gypi?r1=104338&r2=104337&pathrev=104338
 A http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/copy_reg_key_work_item.cc?r1=104338&r2=104337&pathrev=104338 (from /trunk/src/chrome/installer/util/copy_reg_key_work_item.cc revision 101684)
 A http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/copy_reg_key_work_item_unittest.cc?r1=104338&r2=104337&pathrev=104338 (from /trunk/src/chrome/installer/util/copy_reg_key_work_item_unittest.cc revision 101684)
 A http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/copy_reg_key_work_item.h?r1=104338&r2=104337&pathrev=104338 (from /trunk/src/chrome/installer/util/copy_reg_key_work_item.h revision 101684)
 A http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/registry_key_backup.cc?r1=104338&r2=104337&pathrev=104338 (from /trunk/src/chrome/installer/util/registry_key_backup.cc revision 101684)
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/delete_reg_key_work_item.cc?r1=104338&r2=104337&pathrev=104338
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/work_item.cc?r1=104338&r2=104337&pathrev=104338
 A http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/registry_test_data.h?r1=104338&r2=104337&pathrev=104338 (from /trunk/src/chrome/installer/util/registry_test_data.h revision 101684)
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/work_item_list.cc?r1=104338&r2=104337&pathrev=104338
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/chrome_installer.gypi?r1=104338&r2=104337&pathrev=104338
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/work_item_list.h?r1=104338&r2=104337&pathrev=104338
 A http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/registry_test_data.cc?r1=104338&r2=104337&pathrev=104338 (from /trunk/src/chrome/installer/util/registry_test_data.cc revision 101684)
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/work_item.h?r1=104338&r2=104337&pathrev=104338
 A http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/registry_key_backup_unittest.cc?r1=104338&r2=104337&pathrev=104338 (from /trunk/src/chrome/installer/util/registry_key_backup_unittest.cc revision 101684)
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/delete_reg_key_work_item_unittest.cc?r1=104338&r2=104337&pathrev=104338
 A http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/registry_key_backup.h?r1=104338&r2=104337&pathrev=104338 (from /trunk/src/chrome/installer/util/registry_key_backup.h revision 101684)
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/delete_reg_key_work_item.h?r1=104338&r2=104337&pathrev=104338

Merge 101684 - Added CopyRegKeyWorkItem in support of IE low rights policy fixes.

A subsequent CL will contain the rest of the fixes for the bug.

BUG=95810
TEST=installer_util_unittests.exe

Review URL: http://codereview.chromium.org/7890069

TBR=grt@chromium.org
Review URL: http://codereview.chromium.org/8176008
------------------------------------------------------------------------
Labels: merge-merged-835
Comment 15 by bugdro...@chromium.org, Oct 6, 2011 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104345

------------------------------------------------------------------------
r104345 | grt@chromium.org | Thu Oct 06 12:24:38 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/copy_reg_key_work_item.cc?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome_frame/chrome_frame_activex.rgs?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/copy_reg_key_work_item_unittest.cc?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/copy_reg_key_work_item.h?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome_frame/chrome_tab.cc?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/setup/uninstall.cc?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome_frame/chrome_frame_elevation.rgs?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/work_item.cc?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/setup/install_worker.cc?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/work_item_list.cc?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/setup/install.cc?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/setup/setup_main.cc?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/work_item_list.h?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/setup/install_worker_unittest.cc?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/util/work_item.h?r1=104345&r2=104344&pathrev=104345
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/installer/setup/install_worker.h?r1=104345&r2=104344&pathrev=104345

Merge 102569 - Fix in-use updates for Chrome Frame.

On in-use updates, make a copy of the old chrome launcher's IE low rights elevation policy prior to registering the new npchrome_frame.dll so that running instances of IE can still launch Chrome.

In so doing, I also removed elevation policy addition/removal code from the installer so that npchrome_frame.dll's {un,}registration code is the one and only place where this is done.

BUG=95810
TEST=Install a previous version of GCF, run IE and visit some page that activates GCF, update to a version of GCF containing this fix, then try to visit another page that will activate GCF.  If all goes well, you won't see an IE security prompt.

Review URL: http://codereview.chromium.org/7976045

TBR=grt@chromium.org
Review URL: http://codereview.chromium.org/8176009
------------------------------------------------------------------------
Comment 16 by kar...@google.com, Oct 7, 2011 
(No comment was entered for this change.)
Labels: -Merge-Requested Merge-Merged
► Sign in to add a comment

Powered by Google Project Hosting