My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 95568: Calls to window.print() appear to directly open the Chrome Print Preview dialog in Chrome Frame.
5 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  grt@chromium.org
Closed:  May 2013
Cc:  ana...@chromium.org, robertsh...@chromium.org, erikwright@chromium.org

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
 
Project Member Reported by robertsh...@chromium.org, Sep 6, 2011
ChromeFrame version: M13

Related URL(s): Any

Steps to reproduce the issue:
1. Navigate to a page with a button that when clicked calls window.print()
2. Observe the Chrome print preview dialog opening. 

We should hook window.print() and pass the event through the automation api.
Sep 7, 2011
#1 thestig@chromium.org
 Issue 95569  has been merged into this issue.
Sep 7, 2011
#2 robertsh...@google.com
ugh dupes, fyi, there is a discussion on the chrome-frame mailing list here: https://groups.google.com/forum/#!topic/google-chrome-frame/YBviSWlL8Vo about this. 

Turns out that the new Chrome print preview dialog requires the window being printed to remain open and there was a user invoking window.print() and window.close() in rapid succession. Unsure if this counts as a regression or just an artifact of the new design.
Nov 1, 2011
#3 jpfuent...@gmail.com
Is there any work being done on this? I'm experiencing this bug even when *not* passing the GCF http header. 
Nov 1, 2011
#4 robertsh...@chromium.org
@jpfuentes, haven't got to this one yet. Watch here for updates.

Note that the Chrome print dialog will not appear if GCF is not rendering the page. Could you double check the context menu to see whether "About Chrome Frame" appears on the page that causes the Chrome dialog to open?
Dec 13, 2011
#5 ganojipa...@gmail.com
If GCF rendering is showing print dialogue, should there be an option 
to hide this print preview dialogue. 

Feb 14, 2012
#6 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=121891

------------------------------------------------------------------------
r121891 | grt@chromium.org | Tue Feb 14 08:21:27 PST 2012

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/window_print.html?r1=121891&r2=121890&pathrev=121891
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_frame_automation.cc?r1=121891&r2=121890&pathrev=121891
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_launcher.cc?r1=121891&r2=121890&pathrev=121891
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/ui_test.cc?r1=121891&r2=121890&pathrev=121891

Disable Chrome's print preview in Chrome Frame.

BUG=95568
TEST=do something on a page that calls window.print(); expect IE's print dialog to appear.  should be covered by new test in chrome_frame_tests.exe.


Review URL: http://codereview.chromium.org/9350044
------------------------------------------------------------------------
Feb 15, 2012
#7 kenjibaheux@chromium.org
It seems that this is affecting Gmail (saw a window.print() on the print page).
We have an enquiry from a Google Apps customer with the issue, would be nice to have a rough ETA.

Thanks.
Feb 15, 2012
#8 kenjibaheux@chromium.org
In the meantime, is there any workaround?
Feb 15, 2012
#9 grt@chromium.org
Fix first appearing in 19.0.1042.0.  I'd like to merge this into M18 so that we can restore native printing in Chrome Frame before M19.  Thanks.
Status: Fixed
Labels: Mstone-18 Merge-Requested
Feb 15, 2012
#10 grt@chromium.org
(No comment was entered for this change.)
Owner: grt@chromium.org
Cc: -grt@chromium.org robertsh...@chromium.org
Feb 15, 2012
#11 kenjibaheux@chromium.org
Would it be possible to merge that to the current stable M17 since Google Apps users/customers are potentially affected (at least on Gmail)?

grt@ any concerns?
Labels: -Mstone-18 Mstone-17
Feb 15, 2012
#12 grt@chromium.org
The change hasn't been vetted on users' machines yet, so I'd prefer to have it go out in at least one beta push before moving it to stable.  Kerz: please weigh in if you feel strongly one way or the other.
Labels: Mstone-18
Feb 15, 2012
#13 kenjibaheux@chromium.org
OK, I will try to get confirmation from the user who reported the issue asap with Chrome Frame beta.
Labels: -Mstone-17
Feb 15, 2012
#14 grt@chromium.org
The beta doesn't contain this fix yet, so there's no need.  If the issue that the customer experienced was a crash when trying to print, then that was likely  issue 110585 .  A fix for that went out on the stable channel less than an hour ago (see http://googlechromereleases.blogspot.com/2012/02/chrome-stable-update.html).
Feb 15, 2012
#15 kenjibaheux@chromium.org
grt@: you were right, the stable update did it! Thanks.
Feb 27, 2012
#16 kar...@google.com
(No comment was entered for this change.)
Labels: -Merge-Requested Merge-Approved
Feb 27, 2012
#17 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=123785

------------------------------------------------------------------------
r123785 | grt@chromium.org | Mon Feb 27 11:37:56 PST 2012

Changed paths:
 A http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome_frame/test/data/window_print.html?r1=123785&r2=123784&pathrev=123785 (from /trunk/src/chrome_frame/test/data/window_print.html revision 121891)
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome_frame/chrome_launcher.cc?r1=123785&r2=123784&pathrev=123785
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome_frame/chrome_frame_automation.cc?r1=123785&r2=123784&pathrev=123785
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome_frame/test/ui_test.cc?r1=123785&r2=123784&pathrev=123785

Merge 121891 - Disable Chrome's print preview in Chrome Frame.

BUG=95568
TEST=do something on a page that calls window.print(); expect IE's print dialog to appear.  should be covered by new test in chrome_frame_tests.exe.


Review URL: http://codereview.chromium.org/9350044

TBR=grt@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9475014
------------------------------------------------------------------------
Labels: -merge-approved merge-merged-1025
Mar 29, 2012
#18 jasonsc...@gmail.com
Looks like you fixed this in 18 for the users that did not like it but it is now "broken" for anyone that wants to see the print preview. Specifically in Gmail. When using the chrome frame 17 and selecting the print button in an email, this would bring up the print preview and allow the ability to save as PDF. Now, when hitting the print button, chrome frame immediately brings up the system print dialog. any way to get the print preview back.
Mar 29, 2012
#19 grt@chromium.org
Hi Jason.  My apologies for disappointing you and other users who had grown accustomed  to seeing Chrome's print preview.  It was an accident that this ever appeared for sites that called window.print(), and there are a variety of corner cases that made it unreliable (note that File->Print and Ctrl-P have always shown the native print dialog).  We have no immediate plans to support Chrome's print preview within Chrome Frame.

Chrome has many features in addition to the wonderful printing support that you may find appealing.  Have you considered switching to Chrome?
Apr 12, 2012
#20 ed...@chromium.org
Google Apps for Business customer with several thousand seats is dependent on Print to PDF functionality in Chrome Frame's Print Preview feature. Is there a way to remove the "--disable-print-preview" flag from Chrome Frame command line parameters?
Oct 13, 2012
#21 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#22 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Feature-ChromeFrame -Mstone-18 M-18 Cr-ChromeFrame
Mar 13, 2013
#23 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
May 29, 2013
#24 mummare...@chromium.org
I'll handle this one.
Status: Accepted
Owner: mummare...@chromium.org
May 29, 2013
#25 mummare...@chromium.org
I'll handle this one.
May 29, 2013
#26 grt@chromium.org
re-closing
Status: Fixed
Owner: grt@chromium.org
Sign in to add a comment

Powered by Google Project Hosting