| Issue 94848: | Chrome Frame leaving itself in user agent after uninstallation. | |
| 3 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
User Dan Fabulic reports that after uninstalling, his user-agent still contains "chromeframe": Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; chromeframe/13.0.782.218; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729) How is this possible? I've checked and re-checked the list of add-ons; the GCF BHO is absent. I've installed, reinstalled, and uninstalled GCF several times, and rebooted. I've deleted my "Local Settings\Application Settings\Google" folder. At first glance, it looks like we're somehow not cleaning up the CF value in SOFTWARE\Microsoft\Windows\CurrentVersion\Internet Settings\User Agent\Post Platform during uninstallation.
Comment
1
by
robertsh...@chromium.org,
Aug 30, 2011
Labels: -Pri-2 Pri-1
,
Aug 31, 2011
Here's the chrome_frame_installer.log.
,
Aug 31, 2011
For the record, I found the stray "chromeframe" key under HKCU\...\Post Platform, and not in HKLM.
,
Aug 31, 2011
Ok, thanks Dan, as suspected there is a failure during unregistration of Chrome Frame. There is an error code of 0x8002801C, which translates to "Error accessing the OLE registry." I have a patch in the works to make the unregistration step more robust, I'll keep this bug posted with updates. Thanks for the report.
,
Sep 3, 2011
Issue 94847 has been merged into this issue.
,
Sep 8, 2011
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=100224
------------------------------------------------------------------------
r100224 | robertshield@chromium.org | Thu Sep 08 12:45:45 PDT 2011
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/self_reg_work_item.cc?r1=100224&r2=100223&pathrev=100224
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_tab.cc?r1=100224&r2=100223&pathrev=100224
Make Chrome Frame registration and unregistration more robust and make it return extra information in the failure code.
Specifically, there are a series of registration changes made by Chrome Frame at registration and unregistration time. Previously, if any of those changes failed, the previous changes were left and subsequent changes were not made.
During registration this could result in partial registration data being left if one of the items failed which is bad but wasn't a problem in practice, because if ever registration failed, unregistration would then be performed by the installer. Also the most likely step to fail happens first.
During unregistration, if any of the steps fail, the remaining unregistration steps will not be taken. This is bad, as uninstallation is a best effort, "clean up everything you can" type thing.
Changed this to for registration roll back the previous N-1 steps of step N fails and for unregistration to attempt to perform all N steps disregarding failures.
Updated installer logging.
BUG=94848
TEST=Unregistration of e.g. the user-agent modification should always be performed even if an earlier step fails.
Review URL: http://codereview.chromium.org/7824010
------------------------------------------------------------------------
,
Sep 9, 2011
(No comment was entered for this change.)
Labels: Merge-Requested
,
Sep 19, 2011
robert is this a request for 14 or 15?
,
Sep 19, 2011
M15 please.
,
Sep 21, 2011
(No comment was entered for this change.)
Labels: Mstone-15
,
Sep 26, 2011
(No comment was entered for this change.)
Labels: -Merge-Requested Merge-Approved
,
Sep 27, 2011
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=102982
------------------------------------------------------------------------
r102982 | robertshield@chromium.org | Tue Sep 27 11:41:19 PDT 2011
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/installer/util/self_reg_work_item.cc?r1=102982&r2=102981&pathrev=102982
M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome_frame/chrome_tab.cc?r1=102982&r2=102981&pathrev=102982
Merge 100224 - Make Chrome Frame registration and unregistration more robust and make it return extra information in the failure code.
Specifically, there are a series of registration changes made by Chrome Frame at registration and unregistration time. Previously, if any of those changes failed, the previous changes were left and subsequent changes were not made.
During registration this could result in partial registration data being left if one of the items failed which is bad but wasn't a problem in practice, because if ever registration failed, unregistration would then be performed by the installer. Also the most likely step to fail happens first.
During unregistration, if any of the steps fail, the remaining unregistration steps will not be taken. This is bad, as uninstallation is a best effort, "clean up everything you can" type thing.
Changed this to for registration roll back the previous N-1 steps of step N fails and for unregistration to attempt to perform all N steps disregarding failures.
Updated installer logging.
BUG=94848
TEST=Unregistration of e.g. the user-agent modification should always be performed even if an earlier step fails.
Review URL: http://codereview.chromium.org/7824010
TBR=robertshield@chromium.org
Review URL: http://codereview.chromium.org/8055021
------------------------------------------------------------------------
Labels: -merge-approved merge-merged-874
,
Sep 28, 2011
(No comment was entered for this change.)
Status: Fixed
,
Sep 29, 2011
(No comment was entered for this change.)
Status: Verified
|
||||||||||
| ► Sign in to add a comment | |||||||||||
