My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 93609: WebSocket Close method
3 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  toyoshim@chromium.org
Closed:  Sep 2011
Cc:  yutak@chromium.org, toyoshim@chromium.org, tyoshino@chromium.org

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
 
Reported by Bronisla...@bauglir.com, Aug 20, 2011
Chrome Version       : 15.0.854.0 dev-m

WebSocket Close method does not send code and reason to server

Aug 20, 2011
#1 tkent@chromium.org
(No comment was entered for this change.)
Cc: yutak@chromium.org toyoshim@chromium.org
Labels: -Area-Undefined Area-WebKit WebKit-WebSockets
Aug 21, 2011
#2 yutak@chromium.org
We are aware of this and working on a fix.
Status: Assigned
Owner: toyoshim@chromium.org
Labels: Mstone-15
Aug 21, 2011
#3 yutak@chromium.org
 Issue 93608  has been merged into this issue.
Aug 28, 2011
#4 Bronisla...@bauglir.com
it seems to be working on 15.0.861.0 dev-m, is the implementation finished?
Aug 28, 2011
#5 toyoshim@chromium.org
Not finished yet.

The first change to support it is landed, so
receiving close and reason could be shown in its CloseEvent.

But, close's arguments will be still ignored now.
Changes are almost done, but it depends on some other changes.
I'm waiting for reviews.
We need a few more days to land all changes.

Thanks,
Aug 28, 2011
#6 toyoshim@chromium.org
(No comment was entered for this change.)
Status: Started
Sep 2, 2011
#7 toyoshim@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=66362
https://bugs.webkit.org/show_bug.cgi?id=66925

These WebKit changes are already rolled to Chromium.
Status: Fixed
Dec 30, 2011
#8 marcusde...@gmail.com
I am on newest Chromium and bug is still there.
Dec 31, 2011
#9 toyoshim
Originally, this feature was not implemented, but I implemented it and pass tests including third party one.
E.g. http://www.tavendo.de/autobahn/testsuite/report/clients/index.html

If you still have troubles, it might be a new bug.
Please report reproduction processes. It will help to investigate the problem.
Jan 18, 2012
#10 marcusde...@gmail.com
By the newest chromium I meant 15.0.874.106 (Developer Build 107270 Linux) Ubuntu 11.10. I understand that although it is the most recent one in the Ubuntu repos, there are some newer versions. Is it correct that this bug is still present in this version? I also tried it using Chrome 18.0.1010.0 dev, but the behavior remains. If it is of any relevance: I am using a libwebsockets server.
Jan 18, 2012
#11 toyoshim@chromium.org
Could you clarify what's wrong?
I'm not familiar with libwebsockets, and don't know your library version and related server implementation.
Commit log of libwebsockets says support protocol v8 for chrome 15. Protocol v8 looks a little old now, but could be compatible with RFC version. It depends on server implementation.

I'm happy if you check if other clients work fine. Reporting reproduction process help me to fix problems.
Autobahn, I mentioned before, contains server test suites.
It could be useful for you to check your server implementation.
Cc: tyoshino@chromium.org
Jan 30, 2012
#12 marcusde...@gmail.com
I found out that you need to specify the code (100x) with which you want to close in Chrom(e/ium), whereas this wasn't necessary in Firefox. It works beautifully now! Sorry for wasting your time with my ignorance!
Jan 31, 2012
#13 toyoshim@chromium.org
The WebSocket API spec say code and reason are optional for close() method and we implement it so in Chromium. I confirm that Chromium send a client initiated closing handshake frame with no argument. If your server could not detect a closing frame, it might be a bug.

If you specified a code which is out of range defined in spec, equal to 1000 or in the range 3000 to  4999, close() method raises InvalidAccessError exception.

I'm happy if this information is useful for your development.

Thanks
Oct 13, 2012
#14 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#15 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-WebKit -WebKit-WebSockets -Mstone-15 Cr-Content Cr-Content-WebSockets M-15
Mar 13, 2013
#16 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Apr 5, 2013
#17 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Content Cr-Blink
Apr 5, 2013
#18 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Content-WebSockets Cr-Blink-WebSockets
Sign in to add a comment

Powered by Google Project Hosting