My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 92761: Improved support for extensions like AdBlock
38 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by mkwst@chromium.org, Aug 13, 2011
AdBlock and other such extensions have requirements relating to WebRequest and other APIs. This bug will wrap them up for visibility.
Aug 13, 2011
#1 mkwst@chromium.org
(No comment was entered for this change.)
Blocking: 92458
Aug 18, 2011
#2 mkwst@chromium.org
(No comment was entered for this change.)
Blockedon: 93373
Aug 20, 2011
#3 mkwst@chromium.org
(No comment was entered for this change.)
Blockedon: 93542
Aug 25, 2011
#4 mkwst@chromium.org
(No comment was entered for this change.)
Blockedon: 94284
Sep 7, 2011
#5 fam....@live.nl
Just to help you a bit: this are the (not yet blocked_on) issues which bother us the most:
issue 60101 issue 60435 issue 65110 issue 68705  issue 81298  issue 82804
Sep 7, 2011
#6 mkwst@chromium.org
Thanks. I'll add them to the list.

Can you give us a little context about the relative pain these are causing?  For instance, it looks like issue 68705 has been worked around (which doesn't mean it's not a bug, of course), which means fixing it isn't as big a win. How do the others effect users in a concrete way?

That sort of information helps us triage bugs properly.

Blockedon: 60101 60435 65110 68705 81298 82804
Sep 7, 2011
#7 adblockforchrome
In order from most to least impact:

60101: Biggest feature ever.
60435, 65110, 81298: Rarely effects users; it doesn't happen often.  AdBlock has lived with these for a while now.
68705: AdBlock must work around this on a site-specific basis.
82804: Basically no impact; AdBlock works around this.
Sep 7, 2011
#8 fam....@live.nl
60101: agree with Michael
60435, 65110, 81298: when these happen, we have to disable parts of the code (like context menus) for those sites as we need the data from X.tab(s) for the code. Also, I don't know how much additional coding it'll require to fix https://code.google.com/p/adblockforchrome/issues/detail?id=5924#c22
68705: agree with Michael. We must work around it, but then it first has to be reported. I don't know how many sites exist with that issue that simply haven't been reported yet (because users didn't know how to report it, or didn't notice it was due to AdBlock instead of a site issue)
82804: simply causing scripting errors on some sites (including acid3 and the one mentioned in that issue). Running the code twice = spending twice the time to parse everything. But it indeed has no visual impact. @Michael, we don't have a workaround. adblock.js (not adblock_start.js) simply aborts because an variable doesn't exist anymore, but filter parsing etcetera has already happened by then.
Sep 8, 2011
#13 mkwst@chromium.org
(No comment was entered for this change.)
Blockedon: 76571
Sep 8, 2011
#14 mkwst@chromium.org
Thanks guys. I'll feed this back to the extensions team.
Sep 13, 2011
#15 mkwst@chromium.org
New blocker:  issue 96442 . "Let extensions detect whether they were externally installed"
Blockedon: 96442
Sep 18, 2011
#16 fam....@live.nl
I don't think 96442 is AdBlock specific, all extensions could use it and it isn't related to adblocks goal: blocking ads.
 issue 96544  however is.
Sep 21, 2011
#17 mkwst@chromium.org
Adding issue 97392: "[It's] Hard to inform a DOM element that it's been blocked" and  issue 96544 : "AdBlock creates 70 megs of JavaScript string data on mashable.com" (although that latter needs no triage: it's well prioritized already).

Regarding  issue 96442 , however, Michael pointed to it as an interesting feature he'd like to see implemented, but you're right, it's not at all adblock-specific. It doesn't have to be... this wrap-up bug is really just so I can help triage requests internally. :)
Blockedon: 96544 97392
Sep 27, 2011
#18 mkwst@chromium.org
Adding  issue 98048 : "No way to get parent frame ID of <iframe> in webRequest.onBeforeRequest"
Blockedon: 98048
Nov 7, 2011
#19 mkwst@chromium.org
Adding  issue 103018 : "Defective Origins/CURRENT file disables File System API" (which was reported by AdBlock Plus, not AdBlock, just so we know who to talk to).
Blockedon: 103018
Nov 30, 2011
#20 mkwst@chromium.org
(No comment was entered for this change.)
Blockedon: 105981
Dec 8, 2011
#21 mkwst@chromium.org
(No comment was entered for this change.)
Blockedon: 106913
Dec 12, 2011
#22 mihaip@chromium.org
(No comment was entered for this change.)
Blockedon: 63979 107286
Dec 15, 2011
#23 mkwst@chromium.org
(No comment was entered for this change.)
Blockedon: 107759
Jan 5, 2012
#24 mkwst@chromium.org
Adding  Issue 109272 : "In canary, document.documentElement is null at document_start"
Blockedon: 109272
Jan 5, 2012
#25 fam....@live.nl
 issue 108942  and  issue 109352  can be added too, since tabs.getSelected is deprecated and we have to start using tabs.query(...)
Jan 5, 2012
#26 mkwst@chromium.org
Adding  Issue 109352 : 'chrome.tabs.query returns tabs[0].url === "" for target="blank" links when fired from tabs.onSelectionChanged' and  Issue 108942 : 'chrome.tabs.query required a windowId'
Jan 5, 2012
#27 mkwst@chromium.org
Er. Actually adding those issues as blockers. :)
Blockedon: 108942 109352
Jan 6, 2012
#28 fam....@live.nl
And  issue 108198  - Permission upgrade detection seems incorrect, which prevents us from enabling popup blocking by default.
Jan 6, 2012
#29 mkwst@chromium.org
Added.
Blockedon: 108198
Jan 14, 2012
#30 mkwst@chromium.org
Adding  issue 110084 : 'el.style.prop = "val !important" fails'
Blockedon: 110084
Jan 27, 2012
#31 mkwst@chromium.org
Adding Issue #111623: "After an extension update, extension broken for a small percentage of users"
Blockedon: 111623
Feb 24, 2012
#32 mkwst@chromium.org
Adding  Issue #115714 : `chrome.i18n.getMessage` error.
Blockedon: 115714
Mar 1, 2012
#34 fam....@live.nl
Also  issue 55136  (we experience this issue with some images and iframes)
(this issue would also be moot, just like some others, if issue 97392 is fixed, but currently it's still a bug for us)
Mar 2, 2012
#35 mkwst@chromium.org
Adding:

- #115138: "WebNavigation/tabs: nonexistent tab IDs in onCommitted listener"
- #55136: "Image not send through 'beforeload' handler"
Blockedon: 55136 115138
Mar 27, 2012
#36 fam....@live.nl
I just filed issue 120362 which is also useful for AdBlock.
Mar 27, 2012
#37 mkwst@chromium.org
Adding issue 120362: "webRequest blocking iframe: you'll have to press the back button twice"
Blockedon: 120362
Apr 18, 2012
#38 fam....@live.nl
issue 123476 will help us to distinguish between 'the-website-requested' and 'the-user-requested' new tabs.
Although this isn't a very big issue (users would be clicking an ad link anyway), it'd be nice if we were able to really just filter the former of the two.
Apr 18, 2012
#39 mkwst@chromium.org
(No comment was entered for this change.)
Blockedon: 123476
Apr 25, 2012
#40 mkwst@chromium.org
Adding issue 124989, "Extension's content scripts should be allowed to ignore CSP and web_accessible_resources"
Blockedon: 124989
Apr 25, 2012
#41 mkwst@chromium.org
Adding  issue 124988 , "Content security policy shouldn't block about:blank"
Blockedon: 124988
May 16, 2012
#42 fam....@live.nl
I don't know if regressions in the browser affecting AdBlock should also be mentioned here, but if so, I'd like to nominate  issue 128347  
Aug 28, 2012
#43 mkwst@chromium.org
(No comment was entered for this change.)
Blocking: chromium:143236
Mar 9, 2013
#44 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Action-Evangelism Needs-Evangelism
Blockedon: -chromium:55136 -chromium:60101 -chromium:60435 -chromium:63979 -chromium:65110 -chromium:68705 -chromium:76571 -chromium:81298 -chromium:82804 -chromium:92485 -chromium:93373 -chromium:93542 -chromium:94284 -chromium:96442 -chromium:96544 -chromium:97392 -chromium:98048 -chromium:103018 -chromium:105981 -chromium:106913 -chromium:107286 -chromium:107759 -chromium:108198 -chromium:108942 -chromium:109272 -chromium:109352 -chromium:110084 -chromium:111623 -chromium:115138 -chromium:115714 -chromium:120362 -chromium:123476 -chromium:124988 -chromium:124989 chromium:55136 chromium:60101 chromium:60435 chromium:63979 chromium:65110 chromium:68705 chromium:76571 chromium:81298 chromium:82804 chromium:92485 chromium:93373 chromium:93542 chromium:94284 chromium:96442 chromium:96544 chromium:97392 chromium:98048 chromium:103018 chromium:105981 chromium:106913 chromium:107286 chromium:107759 chromium:108198 chromium:108942 chromium:109272 chromium:109352 chromium:110084 chromium:111623 chromium:115138 chromium:115714 chromium:120362 chromium:123476 chromium:124988 chromium:124989
Blocking: -chromium:92458 chromium:92458
Mar 10, 2013
#45 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Feature-Extensions Cr-Platform-Extensions
Sign in to add a comment

Powered by Google Project Hosting