(No comment was entered for this change.)

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=96790

------------------------------------------------------------------------
r96790 | phajdan.jr@chromium.org | Mon Aug 15 10:34:01 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/net.gyp?r1=96790&r2=96789&pathrev=96790
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_unittest.cc?r1=96790&r2=96789&pathrev=96790
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_handler_factory.cc?r1=96790&r2=96789&pathrev=96790
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_handler_factory_unittest.cc?r1=96790&r2=96789&pathrev=96790

Linux: control usage of Kerberos via use_kerberos gyp flag
(on by default)

This allows Linux distro packagers to control usage of Kerberos
explicitly instead of relying on auto-detection.

BUG=92689

Review URL: http://codereview.chromium.org/7633006
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=97925

------------------------------------------------------------------------
r97925 | phajdan.jr@chromium.org | Tue Aug 23 14:46:30 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_gssapi_posix_unittest.cc?r1=97925&r2=97924&pathrev=97925
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_gssapi_posix.h?r1=97925&r2=97924&pathrev=97925
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/mock_gssapi_library_posix.h?r1=97925&r2=97924&pathrev=97925
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_handler_negotiate_unittest.cc?r1=97925&r2=97924&pathrev=97925
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/net.gyp?r1=97925&r2=97924&pathrev=97925
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/mock_gssapi_library_posix.cc?r1=97925&r2=97924&pathrev=97925
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_gssapi_posix.cc?r1=97925&r2=97924&pathrev=97925
 M http://src.chromium.org/viewvc/chrome/trunk/src/build/install-build-deps.sh?r1=97925&r2=97924&pathrev=97925
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_handler_factory.cc?r1=97925&r2=97924&pathrev=97925
 D http://src.chromium.org/viewvc/chrome/trunk/src/net/third_party/gssapi?r1=97925&r2=97924&pathrev=97925

Linux: allow linking directly with Kerberos instead of using dlopen.

dlopen is still the default for Google Chrome. This option
is intended for Linux distro packagers.

BUG=92689

Review URL: http://codereview.chromium.org/7655046
------------------------------------------------------------------------

After that last commit, I get a build error with Gentoo's live ebuild.

In file included from ./net/http/http_auth_handler_negotiate.h:21:0,
                 from net/http/http_auth.cc:14:
./net/http/http_auth_gssapi_posix.h:9:20: fatal error: gssapi.h: No such file or directory
compilation terminated.
make: *** [out/Release/obj.target/net/net/http/http_auth.o] Error 1

#4: The recent CL removed a copy of gssapi.h and assumes that the system has one installed and is in the include path. 

I am building with -Duse_kerberos=0, which should remove the need to have a kerberos library installed at build time.

src/net/net.gyp contains some conditional logic to avoid building http_auth_gssapi_posix.{cc,h} and http_auth_handler_negatotiate.{cc,h} when use_kerberos=0.

I'm thinking some code in http_auth.cc should be conditionally compiled (#ifdef USE_KERBEROS) or the use_kerberos option should be removed.

And now that I read comment #2, I see that Pawel added the use_kerberos option, so removing it seems quite silly. :)

This patch should tide you over until it gets into trunk: http://codereview.chromium.org/download/issue7720018_1.diff

That fixed it, thanks.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=98028

------------------------------------------------------------------------
r98028 | dpolukhin@chromium.org | Wed Aug 24 05:38:19 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_gssapi_posix_unittest.cc?r1=98028&r2=98027&pathrev=98028
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_gssapi_posix.h?r1=98028&r2=98027&pathrev=98028
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/mock_gssapi_library_posix.h?r1=98028&r2=98027&pathrev=98028
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_handler_negotiate_unittest.cc?r1=98028&r2=98027&pathrev=98028
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/net.gyp?r1=98028&r2=98027&pathrev=98028
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/mock_gssapi_library_posix.cc?r1=98028&r2=98027&pathrev=98028
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_gssapi_posix.cc?r1=98028&r2=98027&pathrev=98028
 M http://src.chromium.org/viewvc/chrome/trunk/src/build/install-build-deps.sh?r1=98028&r2=98027&pathrev=98028
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_handler_factory.cc?r1=98028&r2=98027&pathrev=98028

Revert 97925 - Linux: allow linking directly with Kerberos instead of using dlopen.

dlopen is still the default for Google Chrome. This option
is intended for Linux distro packagers.

BUG=92689

Review URL: http://codereview.chromium.org/7655046

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7719024
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=98029

------------------------------------------------------------------------
r98029 | dpolukhin@chromium.org | Wed Aug 24 05:46:41 PDT 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/net/third_party/gssapi/gssapi.h?r1=98029&r2=98028&pathrev=98029
 A http://src.chromium.org/viewvc/chrome/trunk/src/net/third_party/gssapi/README.chromium?r1=98029&r2=98028&pathrev=98029
 A http://src.chromium.org/viewvc/chrome/trunk/src/net/third_party/gssapi/gssapi.gyp?r1=98029&r2=98028&pathrev=98029
 A http://src.chromium.org/viewvc/chrome/trunk/src/net/third_party/gssapi?r1=98029&r2=98028&pathrev=98029
 A http://src.chromium.org/viewvc/chrome/trunk/src/net/third_party/gssapi/LICENSE?r1=98029&r2=98028&pathrev=98029

Fix revert 98028: add file that drover --revert forgot to add

Revert 97925 - Linux: allow linking directly with Kerberos instead of using dlopen.

dlopen is still the default for Google Chrome. This option
is intended for Linux distro packagers.

BUG=92689
Review URL: http://codereview.chromium.org/7655046

TBR=phajdan.jr@chromium.org

Review URL: http://codereview.chromium.org/7719025
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=98111

------------------------------------------------------------------------
r98111 | cbentzel@chromium.org | Wed Aug 24 13:59:56 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth.cc?r1=98111&r2=98110&pathrev=98111

Remove unneeded headers in http_auth.cc

BUG=92689


Review URL: http://codereview.chromium.org/7720018
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=98116

------------------------------------------------------------------------
r98116 | phajdan.jr@chromium.org | Wed Aug 24 14:19:20 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_gssapi_posix_unittest.cc?r1=98116&r2=98115&pathrev=98116
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_gssapi_posix.h?r1=98116&r2=98115&pathrev=98116
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/mock_gssapi_library_posix.h?r1=98116&r2=98115&pathrev=98116
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_handler_negotiate_unittest.cc?r1=98116&r2=98115&pathrev=98116
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/net.gyp?r1=98116&r2=98115&pathrev=98116
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/mock_gssapi_library_posix.cc?r1=98116&r2=98115&pathrev=98116
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_gssapi_posix.cc?r1=98116&r2=98115&pathrev=98116
 M http://src.chromium.org/viewvc/chrome/trunk/src/build/install-build-deps.sh?r1=98116&r2=98115&pathrev=98116
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_handler_factory.cc?r1=98116&r2=98115&pathrev=98116
 D http://src.chromium.org/viewvc/chrome/trunk/src/net/third_party/gssapi?r1=98116&r2=98115&pathrev=98116

Linux: allow linking directly with Kerberos instead of using dlopen.

dlopen is still the default for Google Chrome. This option
is intended for Linux distro packagers.

BUG=92689

Review URL: http://codereview.chromium.org/7655046
------------------------------------------------------------------------

(No comment was entered for this change.)

A little more work is needed to fix this linking error on Gentoo:


out/Release/obj.target/net/net/http/http_auth_gssapi_posix.o: In function `_ZN3net12_GLOBAL__N_111DescribeOidEPNS_13GSSAPILibraryEP19gss_OID_desc_struc
t.isra.19':
http_auth_gssapi_posix.cc:(.text._ZN3net12_GLOBAL__N_111DescribeOidEPNS_13GSSAPILibraryEP19gss_OID_desc_struct.isra.19+0x1ff): undefined reference to `
GSS_C_NT_USER_NAME'
http_auth_gssapi_posix.cc:(.text._ZN3net12_GLOBAL__N_111DescribeOidEPNS_13GSSAPILibraryEP19gss_OID_desc_struct.isra.19+0x240): undefined reference to `
GSS_C_NT_MACHINE_UID_NAME'
http_auth_gssapi_posix.cc:(.text._ZN3net12_GLOBAL__N_111DescribeOidEPNS_13GSSAPILibraryEP19gss_OID_desc_struct.isra.19+0x285): undefined reference to `
GSS_C_NT_STRING_UID_NAME'
http_auth_gssapi_posix.cc:(.text._ZN3net12_GLOBAL__N_111DescribeOidEPNS_13GSSAPILibraryEP19gss_OID_desc_struct.isra.19+0x2ca): undefined reference to `
GSS_C_NT_HOSTBASED_SERVICE_X'
http_auth_gssapi_posix.cc:(.text._ZN3net12_GLOBAL__N_111DescribeOidEPNS_13GSSAPILibraryEP19gss_OID_desc_struct.isra.19+0x30f): undefined reference to `
GSS_C_NT_HOSTBASED_SERVICE'
http_auth_gssapi_posix.cc:(.text._ZN3net12_GLOBAL__N_111DescribeOidEPNS_13GSSAPILibraryEP19gss_OID_desc_struct.isra.19+0x354): undefined reference to `
GSS_C_NT_ANONYMOUS'
http_auth_gssapi_posix.cc:(.text._ZN3net12_GLOBAL__N_111DescribeOidEPNS_13GSSAPILibraryEP19gss_OID_desc_struct.isra.19+0x399): undefined reference to `
GSS_C_NT_EXPORT_NAME'
/usr/lib/gcc/i686-pc-linux-gnu/4.6.1/../../../../i686-pc-linux-gnu/bin/ld: warning: creating a DT_TEXTREL in object.
collect2: ld returned 1 exit status
make: *** [out/Release/chrome] Error 1

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=98824

------------------------------------------------------------------------
r98824 | phajdan.jr@chromium.org | Tue Aug 30 09:10:56 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_gssapi_posix.cc?r1=98824&r2=98823&pathrev=98824

Fix a linking error with -Dlinux_link_kerberos on Gentoo.

BUG=92689

Review URL: http://codereview.chromium.org/7794015
------------------------------------------------------------------------

(No comment was entered for this change.)

(No comment was entered for this change.)

This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

(No comment was entered for this change.)