Maybe there should just be an easy toggle to show the download shelf?  Just like we do 
for bookmarks.  This way if you lose the download shelf, you can get it back easily.  
Maybe it could also always be available on the NTP (at the footer)?  Too much symmetry 
in that?

Wouldn't it be just as easy, and more useful, to open up the downloads page?

I've wanted this feature for ages. Do we want to do the automatic hide on navigate 
still? I think it would be nice to have a keyboard shortcut to show the shelf, since 
it's a much lighter weight operation than opening a new tab and focusing it (which is 
what the download page has).

I support remapping Ctrl+J to toggle the shelf. Usually what I want to find is 
something I've downloaded this session.

+ 1 removing hide on navigate (I can't say I've noticed us hiding on navigate, though)

I am ambivalent about changing the meaning of Ctrl+J - with the shelf being open most 
of the time as-is, I can already get to recent downloads and I use Ctrl+J to get to 
slightly-older downloads, so we'd have to populate the shelf with those older 
downloads, which sounds like a pile of awful.

(No comment was entered for this change.)

(No comment was entered for this change.)

this is much like  Issue 752  btw

This blocks issue 10764 (closing an empty tab immediately after what's being opened
in a new tab is known to be downloaded as Firefox does). 

(No comment was entered for this change.)

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=17595 

------------------------------------------------------------------------
r17595 | thakis@chromium.org | 2009-06-03 20:30:22 -0700 (Wed, 03 Jun 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_window.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_cocoa.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_file.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_uitest.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/save_package.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/save_page_uitest.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/download_item_gtk.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/download_item_gtk.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/download_shelf_gtk.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/download_shelf_gtk.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/download_shelf_view.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/download_shelf_view.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_renderer.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_renderer.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/temp_scaffolding_stubs.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/temp_scaffolding_stubs.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/automation_messages_internal.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/browser_proxy.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/browser_proxy.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/tab_proxy.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/tab_proxy.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/test_browser_window.h?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/ui_test.cc?r1=17595&r2=17594
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/ui_test.h?r1=17595&r2=17594

Move download shelf from per-tab to per-window.  Also disable auto-hiding of
the shelf.

BUG=9025
TEST=Download file in one tab, open new tab, and check that download shelf is
still open. Also try the shelf's close button and the "show all downloads"
link. When saving a file, the download animation should not show up.

Review URL: http://codereview.chromium.org/115740

------------------------------------------------------------------------

 Issue 752  has been merged into this issue.

Hmm -- I am trying this out, and am getting bad behavior -- if I open a browser, create 
the download shelf (right-click any link, hit "save as..."), then go to another tab, 
and return to the first tab, I cannot close the download shelf.

I'm going to open a separate bug for the not closing shelf on tab switch (I think
I've got a fix for it): crbug.com/13369

-1

I don't like this solution. It doens't really solve the issue (what's wrong with a 
label in right in the download shelve, stating "closing this windows doesn't cancel 
the  download"). 

Also, it is confusing: it shows files for a tab which where not downloaded for that 
tab... 

@doekman

I agree with your first point: Making it obvious that closing the window will not 
cancel your downloads is a great thing. How this is to be done, I don't really care.

Your second point about it being confusing I do not agree with. It's actually more 
confusing to me that when I download something it is on a specific tab. So when I'm 
trying to find that button on the download shelf, I'm shuffling through tabs trying 
to find it. This approach is much more intuitive IMHO. Downloads are downloads, and 
they have nothing to do with the current tab. They all go to the same location on the 
filesystem (Mostly), and should be shown together.

I have to disagree. Downloads are relative to the tab in which they originated. If 
you want a central location from which to launch them, then just open the Downloads 
page (Ctrl+J). That has them all in one place, plus unlike the download shelf, it 
holds more than a handful of the last few downloads.

In fact, the current method is quite frustrating since not only do the downloads not 
link with the tab from which they came, but there is no longer a down-arrow icon on 
the tab to indicate that a download occurred. Therefore on sites such as SourceForge, 
if you open several files in new tabs, then it becomes much more difficult to figure 
out which ones have already downloaded the files.

@synet

What exactly do you gain by downloads being per-tab? Explain this to me please. Please 
only provide logical benefits, not personal bias.

A download originates from a link in a tab, so it makes sense to have it listed in 
that same tab rather than all tabs. Don’t forget that Chrome is supposed to be more 
than just a web-browser, it is supposed to be a framework, one principal of which is 
that each tab is a standalone entity. If downloads from one tab are listed in 
another, then it creates a false link between them.

And like I said, the download shelf only holds a few entries, so if you download 
several files from one tab, then the entries of another tab will soon be pushed out. 
Worse, the download shelf is shown in *all* tabs once a download is triggered from 
*any* tab. This means that you could be shown the shelf in a tab with files 
exclusively from another tab, leading to confusion for many novice users, or even 
have the shelf with a bunch of downloads in a tab in which nothing was downloaded at 
all.

Your argument that you get confused and have to shuffle through the tabs to find 
something is a better example of a personal bias since your specific case is solved 
by just using the Downloads page. Besides, if some files are downloaded from another 
tab, then the buttons you are searching for are gone in the whole shelf since it only 
holds the last few items.

The last few items shown is sufficient for most users IMO

I can't imagine any user getting confused by seeing a downlaod from one tab in 
another tab, because the download shelf follows him just like the toolbar and the 
user, espacially a novice one should not care less about the tabs being standalone.

i like the new implementation but i do have a suggestion
there is no reason to cancel the down arrow from the originating tab as long as the 
download is in progress or something to that effect
that would be a nice feature

@synet

I have heard nothing but personal opinions of yours. I have heard no logical 
explanation as to why downloads must be listed per-tab. It's an extra level of 
indirection that has no meaning, and no purpose. If you are doing it just to maintain 
that "each tab is independent" philosophy, then that's just silly. Not everything 
belongs to the tab, that includes downloads.

When you download a file, the goal for all users is to find that file and open it, 
view it, or perform some other operation on the file. This process should not be 
given the additional requirement of also caring about which tab it belongs to. It 
makes no practical sense.

The only thing that belongs to a tab, in this case, is the invocation of the download 
itself. Beyond that, the download does not belong to the tab, it belongs to the 
filesystem. Since the filesystem has no concept of a "tab", and is ambiguous to how 
the file was placed there, or from where, Chromium should not try to obfuscate this 
fact by placing them in each tab.

The thing that will motivate users to use Chromium, or any software for that matter, 
is simplicity, amongst many other important facts. The software has to meet the 
requirements of the problem domain it was designed to solve, and be as simple and 
direct to use as possible. Simplicity motivates usage.

The downloads page (CTRL+J) serves a few purposes:
 * It provides a way to view all downloads ever made
 * It provides additional details not available from the download shelf

Its requirement is NOT to show all downloads for all tabs, since as I said before, 
downloads do not belong to the tab, they belong to the filesystem.

The download shelf serves these purposes:
 * To give a brief overview of the history and current progress of downloads
 * Give a quick and convenient way of opening any files downloaded

The download shelf is NOT designed to be more than that as far as I'm concerned. It 
is representative of only a small subset of the latest file downloads in history.

I've provided logical, practical, and even conceptual reasons as to why downloads are 
NOT specific to the tabs. You have not provided any as to why they should belong to a 
tab. Which means to me you are simply just suffering from feature withdrawals. Time 
to move on. Chromium is an evolving project, and with a community as large as this, 
this decision was made for a reason. Obviously enough people have found that 
downloads being per-tab was wrong, inconsistent, and didn't make any sense. It was 
serious enough that people (programmers) took their free time to redesign the 
feature.

Time to move on man.

I believe having the downloads being on a per tab basis to be more confusing than 
having a single download shelf. The logic behind that:

If the download corresponds to a tab, it is almost like you have 2 pages open in one 
tab at a time. Think of a download (a request to display/open something) just like a 
request for a page (another request to display/open something). In other words, you 
have one section of the tab open to the current page and another open to the 
download. Normally if I want to view two requests, I have to open two tabs. Granted, 
stuff like AJAX and frames blur these lines a little bit, but from the user's 
perspective, they are still trying to perform a request to view something and every 
tab operates in a linear fashion (ie. I can't make the same tab point to addresses). 
If you are going by the whole "framework" idea, then each download should be opened 
in its own tab. Consider the current implementation where the download continues even 
if the tab that started it is closed. This is exactly the opposite idea of the way 
the tab operates - everything else that is associated with the tab stops when the tab 
is closed.

However, creating a new tab for each download would get messy. The "tabs" for each 
download need their own space so that they don't clutter up the tab area at the top 
that is reserved for pages. Instead, we create the download shelf that is essentially 
like the "tabs of downloads" instead of the "tabs of pages" that currently exists. 
Each "download tab" or button on the download shelf corresponds to its own 
independent process. I'm not sure how the downloads are currently implemented, but it 
has to be something along these lines in order for the download to continue when the 
tab is closed.

To give you all some background - the reasons listed for a per-tab shelf were why we 
tried it in the first place. The reasons listed for a per-window shelf are why we're 
trying that now. There are very good arguments for both cases, and at the end of the 
day we decided to live with the other option for a while to see what it's like.

Because Chrome is developed in the open, 'living with it for a while' is something that 
our dev and beta channel customers also have to do. We think that there's nothing like 
real usage to help us understand any given design decision.

If the download shelf is just per-tab, it seems to me that some users would think that 
closing the tab would cancel their download. I think it's more consistent to have it 
per-window.

@theodorejb

Exactly. I know at least 3 co-workers that have asked me if their downloads will get 
canceled if they close the tab. Good point!

I can definitely see the point in trying the per-tab method. Chrome tried a bunch of 
new stuff that I think it got right that other browsers didn't do. However, I agree 
with the users saying that the per window download shelf is the better choice. I was 
one of the users that when first using Chrome said, "oh crap, I closed the tab. where 
did my download go?"

@mattkolb

Happened to me too! I guess after I download something, I expect to have it even after 
closing the browser, let alone the tab, so it seems illogical that closing the tab 
makes it go away. Downloading takes time, I do not intend to keep a tab open while it 
downloads something but the visual information that stays visible about the download 
progress, in the case of per-window-download-bar is absolutely essential.

@progame (#22): Gonna have to agree with you there. I think the little blue arrow that 
shows-up at the top of the tab after downloading something is a good feature. 

I really like it, and would like to see it back.

And as far as the changes go to making the download shelf per window-based... I like 
it. It's definitely a step in the right direction =D

For those asking for the arrow on the tab, what purpose would this serve? Now that the 
download shelf is not per-tab, I don't see how it could be useful.

Sounds like Uncle Bapa likes to browse porn sites and should be using Incognito mode!

But seriously, I get what you are saying but it sounds like what you want is a 
different feature entirely. Probably the ability to add a "check mark" to each tab by 
clicking on a specific spot on the tab. Perhaps a second button next to the close 
button.

In any case, my vote would be to keep things exactly as they are right now.

It does not have to be porn sites. On a site like SourceForge where you want to 
download a program that has several files, it is quite inconvienient to have to click 
the file, then click the server, then wait for the download, then click Back, Back, 
and repeat for each file. Most people would probably just open each file in a 
separate tab to allow them to get the files concurrently. This becomes problematic 
since the download shelf is open accross all tabs and you have to figure out which 
tabs have already downloaded by checking the filenames. This becomes even worse when 
you download several files called “setup.exe” from a few different sites in different 
tabs: which tab did you get setup.exe from? That’s really annoying since you then 
have to be careful which tab you can close and avoid getting the wrong file twice.

@synet...

I close the tab as I start the download. I don't need to view the download page of the 
tab anymore, and I make sure I don't start the same one twice by closing it. If I don't 
close it, I just make sure that I go in order (left to right or right to left) when 
clicking the download link after all of the tabs for each download are open.

Come on guys, we all know everybody's opinion now. All advantages and disadvantages from both 
ways. Just stop spamming everybody with opinions and only post comments when you are really 
sharing a NEW insight or NEW information.

What if everybody here was posting "I think..", "I prefer", "I like", "I...."'s: it would 
completely flood the issue loosing it focus on the important stuff.

Please more the discussion to a forum thread somewhere and to start discussing personal 
preference there.

I greatly prefer per-window behavior.

@synet: If you're downloading several files called "setup.exe", how do you tell
what's what on your filesystem after you've downloaded them?  Unless you intend to
run them all blindly, surely you are saving them with more meaningful filenames, or
in different folders?

This feels a little weird. I just downloaded something in one of my tabs.  The new 
per window download shelf shows up for the window as it's supposed to, and if I tear 
off the tab that I downloaded in, I no longer see the download shelf in the bottom of 
the window for the teared off tab, it's still with the old window.   

This new per-window behavior feels a little inconsistent with Chrome's tab first 
approach. I haven't seen anything else that's per a window like this in Chrome, and I 
feel like doing this way makes things a little murky since there can be multiple 
windows and it's not always clear where you should show the download bar. Maybe if 
you stick with the window shelf paradigm, you can at least modify it to show the 
download shelf on *all* windows? If the concern was that users were getting confused 
if their downloads were still active when the tab closed, then they get just as 
confused if they had 2 windows, initiated a downloaded in the 2nd window, but then 
closed that window while the download was still happening. The download would still 
be active but the user wouldn't have any indication of this, and might think the 
download was lost just like they were thinking on the per tab basis.

The new per-window download shelf as an issue with tab tearing.
It seems that even something as dragging a tab from a window with a single tab will 
make the shelf disappear.

It needs some reworking on what to do in the case of tearing a tab from a window...

Moving to mstone 3 from an older milestone.  Need to triage.

Moving to milestone 3 from an older milestone.  Need to triage.

Didn't we implement this already? Should not be Untriaged then.

(No comment was entered for this change.)

Sorry to bump a closed issue, but it doesn't seem appropriate to open a new one.

I'd like to see a loose binding between tabs and downloads - a compromise that might 
satisfy both crowds. When you move a tab to a new window, its downloads move to that 
window. If you close the tab, its downloads remain in that window's download shelf 
until the window is closed.

Guys, can we just drop it please? You all are trying to make this feature WAY too 
complicated. Just enjoy the nice new feature improvements and move on.