My favorites | Sign in
Logo
Project Home
  
Downloads
  
Wiki
  
Issues
    
New issue | Search
for
| Advanced search | Search tips
Issue 8831: Regression: flickr.com: flicker organize doesn't work in Chrome
3 people starred this issue and may be notified of changes. Back to list
 
Reported by anantha@chromium.org, Mar 16, 2009 
Chrome Version       : <0.2.160.0 and higher>
URLs (if applicable) : http://www.flickr.com/photos/organize/
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 3:
Firefox 3:
IE 7:

What steps will reproduce the problem?
1. http://www.flickr.com/photos/
2. Click on Organize.


What is the expected result?
Flickr organizer should open


What happens instead?
An error message

Please provide any additional information below. Attach a screenshot if
possible.
According to the release notes listed at the following link, two important
check-ins went into 0.2.160.0
http://sites.google.com/a/chromium.org/dev/getting-involved/dev-channel/release-notes

1. Add support for UA spoofing, and spoof Safari's UA string when loading
URLs. Note: I don't think this has anything to do with flickr
2. A new v8 version. I feel that this may be the reason..
flickr.JPG
51.6 KB Download
Comment 1 by anantha@chromium.org, Mar 16, 2009 
 Issue 8830  has been merged into this issue.
Comment 2 by anantha@chromium.org, Mar 16, 2009 
(No comment was entered for this change.)
Labels: Mstone-2.0 Compat-bug-2.0
Comment 3 by laforge@chromium.org, Mar 16, 2009 
On the fence if this is a UA Logic issue, it's not clear what the method _pf is doing from view-
source:http://www.flickr.com/photos/organize/.  It looks like it's supposed to extract the version and compare.  If this 
started occurring in 2.0.160.0 I almost wonder if this could be related to the new regular expression engine that got 
introduced in that release.

...

<script type="text/javascript"> 
 
var b = 1;
var ua = navigator.userAgent;
 
if (_qs_args.force) { // force it to be good
	b = 1;
} else if (window.opera) { // opera
	b = 0;
	var vn = _pf(ua.split('/')[1]);
	
	if (vn >= 9.2) {
		b = 1;
	}
	
	if (ua.toLowerCase().indexOf('wii') != -1) {
		b = 1;
	}
	
} else if (ua.indexOf('MSIE') > 0) { // IE
	if (navigator.appVersion.toLowerCase().indexOf("mac") > 0) {// mac IE
		b = 0;
	} else {
		b = 0;
		if (ua.indexOf("MSIE 5.6") > -1 || ua.indexOf("MSIE 5.5") > -1 || ua.indexOf("MSIE 6") > -1 || ua.indexOf("MSIE 
7") > -1 || ua.indexOf("MSIE 8") > -1) b = 1; // IE PC 5.5 or above is good
	}
} else if (ua.indexOf('Safari') > -1) { // safari
	var wk_str = ua.match(/AppleWebKit\/[1-9\.]+/);
	var wk_v = _pf(wk_str[0].replace('AppleWebKit/', ''));
 
	if (!wk_v || wk_v < 125.2) { // it is less than v 1.2; http://developer.apple.com/internet/safari/uamatrix.html
		b = 0;
	}
	
} else if (ua.indexOf('Mozilla') > -1 && (ua.indexOf('Mozilla/5') == -1 && ua.indexOf('Mozilla/6') == -1 && 
ua.indexOf('Mozilla/7') == -1)) { // moz, not moz 5+
	b = 0;
}
 
if (b) {
	document.write('<style type="text/css">#bad_browser_div{display:none;} #loading_div{display:block;}<\/style>');
}
 
 
</script>
Status: Assigned
Owner: gwil...@chromium.org
Cc: kasp...@chromium.org
Comment 6 by gwilson@chromium.org, Mar 16, 2009 
I found the issue.  Their regex is looking for the numbers 1-9 only, which means when 
we upgraded to WebKit version 530.4, it only matches "53".  Thus,

var wk_str = ua.match(/AppleWebKit\/[1-9\.]+/); // only matches "53"

Should be:

var wk_str = ua.match(/AppleWebKit\/[0-9\.]+/); // matches "530.4" correctly

Nick is helping us reach out to someone at Flickr to fix this.
Cc: nickb...@chromium.org
Labels: Evangelism
Comment 7 by jon@chromium.org, Mar 17, 2009 
The error includes a link to continue anyway:

   Or, if you want to plow ahead and see if maybe your browser will work, go for it.

If you click on "go for it" then everything works fine in 2.0.170.0 (Developer Build 
11729)

Marking as upstream because we are handing this off to Yahoo!
Status: Upstream
Comment 8 by bringthespam, Mar 20, 2009 
This should now be fixed, thanks for the report.
(The UA sniffing for Organizr is a bit particular due to the complicated nature of
the beast, apologies.)
Comment 9 by anantha@chromium.org, Mar 20, 2009 
Thanks for the fix. It works now in chrome 2.0 beta. Build tested: 2.0.169.1
(Official Build 11427)
Status: Fixed
Sign in to add a comment